fix: Correctly parse bencher thresholds - #655
Merged
Merged
Conversation
The `thresholds` input spans several lines, one per measure. Replacing the unquoted array expansion with `read -a` kept only the first line, so every measure after the first lost its flags and the first lost its boundaries; bencher rejected the model with "no boundary provided" and Benchmark main failed at the tracking step. `read -d ''` consumes the input to its end and still splits on all whitespace, reproducing the original token list without globbing. It reports end of input as a failure, hence the trailing `|| true`.
samuelburnham
enabled auto-merge
October 1, 2026 19:08
arthurpaulino
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
thresholdsinput spans several lines, one per measure. Replacing the unquoted array expansion withread -akept only the first line, so every measure after the first lost its flags and the first lost its boundaries; bencher rejected the model with "no boundary provided" and Benchmark main failed at the tracking step.read -d ''consumes the input to its end and still splits on all whitespace, reproducing the original token list without globbing. It reports end of input as a failure, hence the trailing|| true.Fixes https://github.com/argumentcomputer/ix/actions/runs/36905045151