Skip to content

fix: Correctly parse bencher thresholds #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelburnham merged 1 commit into from
Oct 1, 2026
Merged

fix: Correctly parse bencher thresholds #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/actions/bencher-track/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ runs:
# No data points since the reset → omit thresholds so the reset commit
# lands without an alert (--thresholds-reset clears stale models); they
# re-arm next run. Otherwise substitute the window into each measure.
# The input spans several lines, so read to end of input (`-d ''`)
# rather than to the first newline; `read` then reports end of input
# as a failure, hence `|| true`.
thresholds=()
[ "$sample" -gt 0 ] && read -r -a thresholds <<< "${THRESHOLDS//__WINDOW__/$sample}"
[ "$sample" -gt 0 ] && read -r -d '' -a thresholds <<< "${THRESHOLDS//__WINDOW__/$sample}" || true

bencher run \
--project ix \
Expand Down
Loading