Repository navigation
Conversation
| allowed_types=["registeredOffice", "recordsOffice"], | ||
| required_types=[], | ||
| bc_req=False, | ||
| bc_req=True, |
There was a problem hiding this comment.
Updating as records/registered offices require a BC address for delivery addresses.
a02cae1 to
cb78bda
Compare
kialj876
left a comment
kialj876
left a comment
There was a problem hiding this comment.
Looks good to me, but a few comments to confirm below
| return None | ||
|
|
||
|
|
||
| def validate_office_mailing_addresses(offices: dict, filing_type: str) -> list: |
There was a problem hiding this comment.
Are you sure this is this right?
Colin did not require the mailing address to be in BC so this might cause complaints for cases where they had an existing mailing address outside BC and now due to bad data they can't keep that address
There was a problem hiding this comment.
I had based this on the incorporation flow, where I had looked into the address validation requirements, but you're right — the other filings don't require the mailing address to be in BC either. I'll revert that check and keep the existing delivery address validation as is.
|
|
||
| for index, relationship in enumerate(relationships): | ||
| identifier = relationship.get("entity", {}).get("identifier") | ||
| if identifier and identifier not in active_party_ids: |
There was a problem hiding this comment.
Should this also reject when there's no identifier? I don't think we want to allow new directors here do we?
There was a problem hiding this comment.
I believe this case should be covered by the schema here: https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/review_imported_data.json#L44
|
This branch has not been deployed
3 participants
Issue #: /bcgov/entity#35081
Description of changes:
reviewImportedDatafilings, including updating registered office and records office addresses and director addresses.review-imported-datainenable-new-featureBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).