35081 - Update Filer for Review Imported Data Filing

legal-api/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "legal-api"
-version = "3.1.46"
+version = "3.1.47"
 description = ""
 authors = [
     {name = "thor",email = "1042854+thorwolpert@users.noreply.github.com"}

legal-api/src/legal_api/services/authz.py

@@ -166,7 +166,7 @@
     return any(bool(jwt.validate_roles(request_ctx.current_user, [role])) for role in roles)
 
 
-def get_allowable_filings_dict(is_authorization: bool = False):
+def get_allowable_filings_dict(is_authorization: bool = False):  # noqa: PLR0912
     """Return dictionary containing rules for when filings are allowed."""
     # importing here to avoid circular dependencies
     # pylint: disable=import-outside-toplevel
@@ -708,6 +708,16 @@
             else:
                 del allowable_filings_dict[user_type][Business.State.ACTIVE.value][filing_type]
 
+    enabled_features = flags.value(
+        "enable-new-feature",
+        request_context.user,
+        request_context.account_id,
+    ) or []
+    if "reviewImportedData" not in enabled_features:
+        for user_type_dict in allowable_filings_dict.values():
+            for business_state_dict in user_type_dict.values():
+                business_state_dict.pop("reviewImportedData", None)
+
     # Remove some alteration blockers when authorization is not required
     if not is_authorization:
         for user_type_dict in allowable_filings_dict.values():

legal-api/src/legal_api/services/filings/validations/review_imported_data.py

@@ -45,7 +45,7 @@ def validate(business: Business, imported_data: dict) -> Error:
                 filing_type,
                 allowed_types=["registeredOffice", "recordsOffice"],
                 required_types=[],
-                bc_req=False,
+                bc_req=True,
             )
         )
 

legal-api/src/legal_api/services/filings/validations/validation.py

@@ -203,7 +203,11 @@ def validate(business: Business,  # noqa: PLR0915, PLR0912, PLR0911
                     err = registration_validate(filing_json)
 
                 elif k == Filing.FILINGS["reviewImportedData"].get("name"):
-                    err = review_imported_data_validate(business,filing_json)
+                    enabled_features = flags.value("enable-new-feature", account_id=account_id) or []
+                    if "reviewImportedData" not in enabled_features:
+                        err = Error(HTTPStatus.FORBIDDEN, [{"error": "Review Imported Data filing is not enabled."}])
+                    else:
+                        err = review_imported_data_validate(business, filing_json)
 
                 elif k == Filing.FILINGS["changeOfRegistration"].get("name"):
                     err = change_of_registration_validate(business, filing_json)

legal-api/tests/unit/resources/v2/test_business.py

@@ -1036,7 +1036,7 @@ def test_get_could_file(session, client, jwt, monkeypatch):
     monkeypatch.setattr(
         'legal_api.services.flags.value',
         lambda flag, _user, _account_id: "changeOfLiquidators.appointLiquidator,changeOfLiquidators.ceaseLiquidator,changeOfLiquidators.changeAddressLiquidator,changeOfLiquidators.intentToLiquidate,changeOfLiquidators.liquidationReport,changeOfReceivers.amendReceiver,changeOfReceivers.appointReceiver,changeOfReceivers.ceaseReceiver,changeOfReceivers.changeAddressReceiver,dissolution.delay,transition"
-        if flag == 'enabled-specific-filings' else {}
+        if flag == 'enabled-specific-filings' else ['reviewImportedData'] if flag == 'enable-new-feature' else {}
     )
     monkeypatch.setattr(
         'business_model.models.User.get_or_create_user_by_jwt',

legal-api/tests/unit/services/filings/validations/test_review_imported_data.py

@@ -119,6 +119,23 @@ def test_validate_offices_only(session):
     assert err is None
 
 
+def test_validate_rejects_review_imported_data_when_feature_is_disabled(session, monkeypatch):
+    """Reject the filing when reviewImportedData is absent from the feature flag."""
+    business = _setup_business()
+    filing = _build_filing({
+        "offices": {
+            "registeredOffice": _valid_office(),
+        },
+    })
+    monkeypatch.setattr("legal_api.services.flags.value", lambda *args, **kwargs: [])
+
+    err = validate(business, filing)
+
+    assert err is not None
+    assert err.code == HTTPStatus.FORBIDDEN
+    assert err.msg == [{"error": "Review Imported Data filing is not enabled."}]
+
+
 def test_validate_relationships_only(session):
     """Assert a filing containing relationships only passes validation."""
     business = _setup_business()
@@ -153,6 +170,36 @@ def test_validate_offices_and_relationships(session):
     assert err is None
 
 
+@pytest.mark.parametrize(
+    "office_type,address_type",
+    [
+        ("registeredOffice", "deliveryAddress"),
+        ("registeredOffice", "mailingAddress"),
+        ("recordsOffice", "deliveryAddress"),
+        ("recordsOffice", "mailingAddress"),
+    ],
+)
+def test_validate_requires_bc_region_for_office_addresses(session, office_type, address_type):
+    """Require BC region for delivery addresses, but allow other regions for mailing addresses."""
+    business = _setup_business()
+    office = _valid_office()
+    office[address_type]["addressRegion"] = "AB"
+    filing = _build_filing({"offices": {office_type: office}})
+
+    err = validate(business, filing)
+
+    if address_type == "mailingAddress":
+        assert err is None
+    else:
+        expected_path = f"/filing/reviewImportedData/offices/{office_type}"
+        assert err is not None
+        assert err.code == HTTPStatus.BAD_REQUEST
+        assert any(
+            item["error"] == "Address Region must be 'BC'." and item["path"] == expected_path
+            for item in err.msg
+        )
+
+
 def test_validate_rejects_unknown_director_identifier(session):
     """Assert a relationship identifier that is not an active director is rejected."""
     business = _setup_business()