Repository navigation
Catch Windows build failures in the ci - #497
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
=======================================
Coverage 72.84% 72.84%
=======================================
Files 18 18
Lines 1204 1204
Branches 113 113
=======================================
Hits 877 877
Misses 327 327 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Fix-windows-job-ci
branch
3 times, most recently
from
October 8, 2026 16:30
2e3234a to
b36b4db
Compare
mcbarton
changed the title
mcbarton
commented
Oct 8, 2026
mcbarton
force-pushed
the
Fix-windows-job-ci
branch
from
October 8, 2026 19:10
1e353ef to
4873377
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Fix-windows-job-ci
branch
from
October 9, 2026 08:35
2c10b50 to
8901bf4
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
marked this pull request as ready for review
October 9, 2026 08:41
mcbarton
requested review from
JohanMabille,
SylvainCorlay,
anutosh491 and
vgvassilev
October 9, 2026 08:42
mcbarton
force-pushed
the
Fix-windows-job-ci
branch
from
October 14, 2026 09:23
8901bf4 to
d342b36
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Fix-windows-job-ci
branch
from
October 14, 2026 10:31
d342b36 to
13a01db
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
@JohanMabille pinging for review |
JohanMabille
approved these changes
Oct 15, 2026
Collaborator
|
Can you open an issue to track the failure on Windows? So that we don't forget to fix it on the long run. |
This was referenced Oct 15, 2026
Collaborator
Author
Done. I have opened up two issues. One about the failing test. The other about the broken check-xeus-cpp target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently fail to run xeus-cpps interpreter tests on main (see https://github.com/compiler-research/xeus-cpp/actions/runs/37706898063/job/113083327005#step:10:217), but it isn't detected since we don't fail on Windows for a non zero return fail. This PR introduces Error-OnFailure that has been used sucessfully in CppInterOp for a while to detect Windows errors. This PR will be ready once the ci passes in this PR.