Repository navigation
Conversation
conache
force-pushed
the
focil-add-il-bits-to-bid
branch
from
October 7, 2026 12:51
1547fdf to
5769b3e
Compare
conache
force-pushed
the
focil-block-production-il-bits-handling
branch
from
October 8, 2026 11:22
05a37dd to
4d00fe2
Compare
Owner
Author
|
Closing in favor of sigp#10266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of the FOCIL implementation. This PR adds the
inclusion_list_bitshandling to block production:Proposed Changes
inclusion_list_bitsdon't cover the node's inclusion list bits view. Direct builder bids are checked inverify_direct_bid. The cached bids received on gossip are re-checked at block production, since gossip verification only considered the timely inclusion lists at the time the bid arrived.inclusion_list_bitsfrom the node's inclusion list bits viewonly_timely=Falsein the spec). If it can't be read the bits are empty: the local bid claims no inclusion lists and external bids aren't held to anyAdditional Info
verify_bid_inclusion_list_bitshelper, next to the other checks the gossip and direct verifiers share. sigp#10263 uses the same helper on the gossip layer. Both PRs add this helper, so whichever merges first carries it, and the other rebases on it