Skip to content

Add inclusion list bits handling to block production - #12

Closed
conache wants to merge 11 commits into
focil-add-il-bits-to-bidfrom
focil-block-production-il-bits-handling
Closed

conache wants to merge 11 commits into
focil-add-il-bits-to-bidfrom
focil-block-production-il-bits-handling

Conversation

@conache

@conache conache commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Issue Addressed

Part of the FOCIL implementation. This PR adds the inclusion_list_bits handling to block production:

  • the local bid sets its bits from the inclusion lists the node has stored for the previous slot (per builder spec)
  • external bids whose bits are not inclusive of those inclusion lists are skipped in bid selection (per validator spec)

Proposed Changes

  • In the bid selection logic, skip external bids whose inclusion_list_bits don't cover the node's inclusion list bits view. Direct builder bids are checked in verify_direct_bid. The cached bids received on gossip are re-checked at block production, since gossip verification only considered the timely inclusion lists at the time the bid arrived.
  • In the local bid creation logic, set the bid's inclusion_list_bits from the node's inclusion list bits view
  • The node's inclusion list bits view is read once when producing a block and shared by both flows, considering both timely and untimely inclusion lists (only_timely=False in the spec). If it can't be read the bits are empty: the local bid claims no inclusion lists and external bids aren't held to any

Additional Info

  • The inclusivity check lives in a shared verify_bid_inclusion_list_bits helper, next to the other checks the gossip and direct verifiers share. sigp#10263 uses the same helper on the gossip layer. Both PRs add this helper, so whichever merges first carries it, and the other rebases on it

@conache
conache changed the base branch from unstable to focil-add-il-bits-to-bid September 24, 2026 16:28
@conache
conache marked this pull request as ready for review September 24, 2026 19:01
@conache
conache force-pushed the focil-add-il-bits-to-bid branch from 1547fdf to 5769b3e Compare October 7, 2026 12:51
@conache
conache force-pushed the focil-block-production-il-bits-handling branch from 05a37dd to 4d00fe2 Compare October 8, 2026 11:22
@conache

conache commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

Closing in favor of sigp#10266

@conache conache closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant