[unv-unv]

No description provided.

[unv-unv]

@claude review pr with inline comments

[github-actions]

Claude finished @unv-unv's task in 4m 8s —— View job

---

PR Review — @OverRide annotations (part 2)

• Gather context (diff, changed files)
• Analyze changes for correctness & consistency
• Post inline review comments

Summary

This is a clean, mechanical pass over 54 generated DOM interfaces. Two things happen throughout:

1. @Override added to the inherited task attributes (getCondition, getContinueOnError, getArchitecture, getRuntime, getOutputs, addOutput, and the CreatePriConfigXml* / SimpleItem families). These correctly annotate re-declarations of super-interface methods — good, and they'll catch signature drift at compile time.
2. Extraneous blank lines removed (leading blank after the header comment, doubled blanks between members, trailing blanks before }).

I verified the deletions are only blank lines / re-indentation — no method declarations, imports, or annotations were dropped. @Nonnull, @Required, and Javadoc are all preserved.

One issue worth fixing before merge

Indentation: the added lines use 4 spaces, but every file is tab-indented.

All ~409 added @Override lines are inserted with a 4-space prefix instead of a hard tab, so each annotated declaration now mixes tabs and spaces (the @Nonnull above uses a tab, the new @Override uses spaces). In a handful of files — e.g. GetFrameworkSdkPackages.java — the method signature line itself was also converted from a tab to spaces.

I've left inline suggestion blocks on a few representative lines, but this is best fixed globally: replace the leading 4-space prefix on the added @Override (and re-indented signature) lines with a tab across the branch.

Fix all indentation →

Nothing else stands out — the refactoring itself is correct. Once indentation is normalized this is good to go. ✅
• branch overrides-2

[github-actions]

Indentation: the added @Override is indented with 4 spaces, while this file (including the @Nonnull on the line above) uses hard tabs, so it now mixes tabs and spaces within a single declaration. This applies to all ~409 @Override lines added across this PR — a project-wide replace of the 4-space prefix with a tab would fix them all.

Suggested change

	@Override
	@Override

[github-actions]

Same indentation issue here: @Override uses 4 spaces while the surrounding file uses hard tabs. See the note on CreateAppStoreContainer.java — it applies to every @Override added in this PR.

Suggested change

	@Override
	@Override

[github-actions]

Same 4-spaces-vs-tabs indentation issue on the added @Override.

Suggested change

	@Override
	@Override

[github-actions]

Here both the @Override and the method signature were re-indented from tabs to 4 spaces, so this declaration no longer lines up with the tab-indented @Nonnull just above it. Restore tabs:

Suggested change

	@Override
	GenericAttributeValue<Boolean> getContinueOnError();
	@Override
	GenericAttributeValue<Boolean> getContinueOnError();