Skip to content

Adding missing @Override annotations (part 2). Some refactoring #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VISTALL merged 1 commit into from
Jul 22, 2026
Merged

Adding missing @Override annotations (part 2). Some refactoring #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions api/src/main/java/consulo/msbuild/dom/CreateAppStoreContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Generated on Sat Jan 28 04:58:19 MSK 2017
// DTD/Schema : http://schemas.microsoft.com/developer/msbuild/2003

package consulo.msbuild.dom;

import java.util.List;
Expand All @@ -18,7 +17,6 @@
*/
public interface CreateAppStoreContainer extends DomElement, Task
{

/**
* Returns the value of the Items child.
*
Expand All @@ -28,7 +26,6 @@ public interface CreateAppStoreContainer extends DomElement, Task
@Required
GenericAttributeValue<String> getItems();


/**
* Returns the value of the ProjectName child.
*
Expand All @@ -38,7 +35,6 @@ public interface CreateAppStoreContainer extends DomElement, Task
@Required
GenericAttributeValue<String> getProjectName();


/**
* Returns the value of the OutputPath child.
*
Expand All @@ -47,7 +43,6 @@ public interface CreateAppStoreContainer extends DomElement, Task
@Nonnull
GenericAttributeValue<String> getOutputPath();


/**
* Returns the value of the Condition child.
* <pre>
Expand All @@ -58,9 +53,9 @@ public interface CreateAppStoreContainer extends DomElement, Task
* @return the value of the Condition child.
*/
@Nonnull
@Override

@github-actions github-actions Bot Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation: the added @Override is indented with 4 spaces, while this file (including the @Nonnull on the line above) uses hard tabs, so it now mixes tabs and spaces within a single declaration. This applies to all ~409 @Override lines added across this PR — a project-wide replace of the 4-space prefix with a tab would fix them all.

Suggested change
@Override
@Override

GenericAttributeValue<String> getCondition();


/**
* Returns the value of the ContinueOnError child.
* <pre>
Expand All @@ -71,9 +66,9 @@ public interface CreateAppStoreContainer extends DomElement, Task
* @return the value of the ContinueOnError child.
*/
@Nonnull
@Override
GenericAttributeValue<Boolean> getContinueOnError();


/**
* Returns the value of the Architecture child.
* <pre>
Expand All @@ -86,9 +81,9 @@ public interface CreateAppStoreContainer extends DomElement, Task
* @return the value of the Architecture child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getArchitecture();


/**
* Returns the value of the Runtime child.
* <pre>
Expand All @@ -101,9 +96,9 @@ public interface CreateAppStoreContainer extends DomElement, Task
* @return the value of the Runtime child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getRuntime();


/**
* Returns the list of Output children.
* <pre>
Expand All @@ -114,14 +109,14 @@ public interface CreateAppStoreContainer extends DomElement, Task
* @return the list of Output children.
*/
@Nonnull
@Override
List<Output> getOutputs();

/**
* Adds new child to the list of Output children.
*
* @return created child
*/
@Override
Output addOutput();


}
18 changes: 6 additions & 12 deletions api/src/main/java/consulo/msbuild/dom/CreateCSharpManifestResourceName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Generated on Sat Jan 28 04:58:19 MSK 2017
// DTD/Schema : http://schemas.microsoft.com/developer/msbuild/2003

package consulo.msbuild.dom;

import java.util.List;
Expand All @@ -18,7 +17,6 @@
*/
public interface CreateCSharpManifestResourceName extends DomElement, Task
{

/**
* Returns the value of the PrependCultureAsDirectory child.
*
Expand All @@ -27,7 +25,6 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
@Nonnull
GenericAttributeValue<Boolean> getPrependCultureAsDirectory();


/**
* Returns the value of the ResourceFiles child.
*
Expand All @@ -37,7 +34,6 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
@Required
GenericAttributeValue<String> getResourceFiles();


/**
* Returns the value of the ResourceFilesWithManifestResourceNames child.
*
Expand All @@ -46,7 +42,6 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
@Nonnull
GenericAttributeValue<String> getResourceFilesWithManifestResourceNames();


/**
* Returns the value of the RootNamespace child.
*
Expand All @@ -55,7 +50,6 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
@Nonnull
GenericAttributeValue<String> getRootNamespace();


/**
* Returns the value of the Condition child.
* <pre>
Expand All @@ -66,9 +60,9 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
* @return the value of the Condition child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getCondition();


/**
* Returns the value of the ContinueOnError child.
* <pre>
Expand All @@ -79,9 +73,9 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
* @return the value of the ContinueOnError child.
*/
@Nonnull
@Override
GenericAttributeValue<Boolean> getContinueOnError();


/**
* Returns the value of the Architecture child.
* <pre>
Expand All @@ -94,9 +88,9 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
* @return the value of the Architecture child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getArchitecture();


/**
* Returns the value of the Runtime child.
* <pre>
Expand All @@ -109,9 +103,9 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
* @return the value of the Runtime child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getRuntime();


/**
* Returns the list of Output children.
* <pre>
Expand All @@ -122,14 +116,14 @@ public interface CreateCSharpManifestResourceName extends DomElement, Task
* @return the list of Output children.
*/
@Nonnull
@Override
List<Output> getOutputs();

/**
* Adds new child to the list of Output children.
*
* @return created child
*/
@Override
Output addOutput();


}
18 changes: 6 additions & 12 deletions api/src/main/java/consulo/msbuild/dom/CreateItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Generated on Sat Jan 28 04:58:19 MSK 2017
// DTD/Schema : http://schemas.microsoft.com/developer/msbuild/2003

package consulo.msbuild.dom;

import java.util.List;
Expand All @@ -16,7 +15,6 @@
*/
public interface CreateItem extends DomElement, Task
{

/**
* Returns the value of the AdditionalMetadata child.
*
Expand All @@ -25,7 +23,6 @@ public interface CreateItem extends DomElement, Task
@Nonnull
GenericAttributeValue<String> getAdditionalMetadata();


/**
* Returns the value of the Exclude child.
*
Expand All @@ -34,7 +31,6 @@ public interface CreateItem extends DomElement, Task
@Nonnull
GenericAttributeValue<String> getExclude();


/**
* Returns the value of the Include child.
*
Expand All @@ -43,7 +39,6 @@ public interface CreateItem extends DomElement, Task
@Nonnull
GenericAttributeValue<String> getInclude();


/**
* Returns the value of the PreserveExistingMetadata child.
*
Expand All @@ -52,7 +47,6 @@ public interface CreateItem extends DomElement, Task
@Nonnull
GenericAttributeValue<Boolean> getPreserveExistingMetadata();


/**
* Returns the value of the Condition child.
* <pre>
Expand All @@ -63,9 +57,9 @@ public interface CreateItem extends DomElement, Task
* @return the value of the Condition child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getCondition();


/**
* Returns the value of the ContinueOnError child.
* <pre>
Expand All @@ -76,9 +70,9 @@ public interface CreateItem extends DomElement, Task
* @return the value of the ContinueOnError child.
*/
@Nonnull
@Override
GenericAttributeValue<Boolean> getContinueOnError();


/**
* Returns the value of the Architecture child.
* <pre>
Expand All @@ -91,9 +85,9 @@ public interface CreateItem extends DomElement, Task
* @return the value of the Architecture child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getArchitecture();


/**
* Returns the value of the Runtime child.
* <pre>
Expand All @@ -106,9 +100,9 @@ public interface CreateItem extends DomElement, Task
* @return the value of the Runtime child.
*/
@Nonnull
@Override
GenericAttributeValue<String> getRuntime();


/**
* Returns the list of Output children.
* <pre>
Expand All @@ -119,14 +113,14 @@ public interface CreateItem extends DomElement, Task
* @return the list of Output children.
*/
@Nonnull
@Override
List<Output> getOutputs();

/**
* Adds new child to the list of Output children.
*
* @return created child
*/
@Override
Output addOutput();


}
Loading
Loading