Skip to content

fix: remove catalog delete-by-type command #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeff-schnitter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove catalog delete-by-type command #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions cortexapps_cli/commands/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,24 +122,6 @@ def delete(

client.delete("api/v1/catalog/" + tag)

@app.command()
def delete_by_type(
ctx: typer.Context,
types: CatalogCommandOptions.types = None,
):
"""
Dangerous operation that will delete all entities that are of the given type
"""
client = ctx.obj["client"]

#TODO: check if types is a regex of form: ([-A-Za-z]+,)+

params = {
"types": types
}

client.delete("api/v1/catalog", params=params)

@app.command()
def descriptor(
ctx: typer.Context,
Expand Down
5 changes: 0 additions & 5 deletions data/run-time/catalog-delete-by-type-entity.yaml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions data/run-time/entity-type-delete-by-type.json
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions tests/test_catalog_delete_by_type.py
View file
Open in desktop

This file was deleted.

Loading