Skip to content

feat(mantine): open Anchor links to another origin in a new tab (ADUI-11648) - #4673

Merged
GermainBergeron merged 2 commits into
ADUI-11648-add-anchor-externalfrom
ADUI-11648-anchor-external-new-tab
Oct 29, 2026
Merged

GermainBergeron merged 2 commits into
ADUI-11648-add-anchor-externalfrom
ADUI-11648-anchor-external-new-tab

Conversation

@GermainBergeron

@GermainBergeron GermainBergeron commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Proposed Changes

ADUI-11648 — Anchor now opens links to another origin (compared with window.location.origin) in a new tab with rel="noopener noreferrer", like admin-ui's Anchor wrapper. Explicit target/rel still win. Stacked on #4645.

Potential Breaking Changes

Existing Anchors pointing to another origin will now open in a new tab.

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • A changeset is added for releasable changes, following CONTRIBUTING.md
  • README.md is adjusted to reflect the proposed changes (if relevant)

@svcsnykcoveo

svcsnykcoveo commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown
Contributor

Release Preview

This PR would bump 1 package version if it were merged and released from master.

Minor

Package Next
@coveord/plasma-mantine 61.6.0

@github-actions

Copy link
Copy Markdown
Contributor

Live demo of your latest successful build available here:

@GermainBergeron
GermainBergeron marked this pull request as ready for review October 28, 2026 15:36
@GermainBergeron
GermainBergeron requested a review from a team as a code owner October 28, 2026 15:36
@GermainBergeron
GermainBergeron requested review from FelixBlaisThon and gdostie and a balanced review from Copilot and removed request for a team October 28, 2026 15:36
@GermainBergeron
GermainBergeron force-pushed the ADUI-11648-anchor-external-new-tab branch from 1240c95 to 8e9148a Compare October 28, 2026 15:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change has unresolved hydration mismatches, undefined prop overrides that remove external-link defaults, and a breaking navigation behavior change incorrectly marked as minor without migration guidance.

3 open issues
What changed in this PR

Building on Anchor.External from #4645, this PR makes Plasma’s standard Anchor open cross-origin links in a new tab by default.

Changes:

  • Adds automatic cross-origin detection with _blank and noopener noreferrer defaults, while allowing explicit overrides.
  • Adds tests for origin handling, overrides, and changing or invalid destinations.
  • Updates Storybook guidance, the LLM specification, and release notes.
File Description
packages/​storybook/​src/​components/​call-to-action/​Anchor.stories.tsx Updates the documented default target.
packages/​storybook/​src/​components/​call-to-action/​Anchor.mdx Explains automatic new-tab behavior.
packages/​mantine/​src/​components/​Anchor/​Anchor.tsx Implements cross-origin link defaults.
packages/​mantine/​src/​components/​Anchor/​__tests__/​Anchor.spec.tsx Tests navigation defaults and edge cases.
packages/​llms/​src/​components/​Anchor.md Documents the behavior and overrides for consumers.
.changeset/​clever-lions-wander.md Adds a release note for the navigation change.

Review effort: Balanced

Comment thread .changeset/clever-lions-wander.md Resolved
@GermainBergeron
GermainBergeron force-pushed the ADUI-11648-anchor-external-new-tab branch from 8e9148a to 2bccfdc Compare October 29, 2026 16:14
@GermainBergeron
GermainBergeron enabled stacked auto-merge (squash) October 29, 2026 17:58
@GermainBergeron
GermainBergeron merged commit 8465c79 into master Oct 29, 2026
22 checks passed
@GermainBergeron
GermainBergeron deleted the ADUI-11648-anchor-external-new-tab branch October 29, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants