Repository navigation
Fix short word warning triggering on 2-cell words with rebuses - #592
Merged
Merged
Conversation
Member
|
Thank you! |
Member
|
We probably should add a warning for isolated 1 letter entries like that but that'd be a separate issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #587
Evidence of fix
IPADandDPAD) no longer trigger a publish warning.IDandII) continue to trigger a warning.HI) are not considered clueable (same as before).Test case
I've also added a corresponding test case. It took me longer than I'd care to admit to work out the empty strings in the other test cases represent unfilled cells rather than blocks. I'm hoping the added unicode crossword comment makes the logic clearer for future new devs.