Repository navigation
diff_versions: list the used names check_symbols cant check, with the reason - #22
Merged
Merged
Conversation
DT-CORE-61: a used path whose module another distribution installs into a namespace read as nothing changed. DiffResult gains unchecked_uses, with the end it is unknown at and the same hint check_symbols gives, and note says so; never_seen keeps its meaning. Signed-off-by: rise11hx-cmyk <rise11hx@gmail.com>
Owner
|
Thanks, @rise11hx-cmyk, merged. Building the list in its own pass turned out better than what I suggested: on langgraph 0.2.76 → 0.3.1 it now also names |
cschmertz
added a commit
that referenced
this pull request
Nov 18, 2026
…E-61) Changelog entry for the new unchecked_uses field from #22, and DT-CORE-61 moves from the held gaps to done. The bench side, counting such an answer as an abstention, is still to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16 (DT-CORE-61). When a used name's module comes from a distribution DepTime doesn't index,
diff_versionsused to answerevents: []and no note, which reads as "nothing changed". It now says it couldn't check.What changed
DiffResultgainsunchecked_uses: list[UncheckedUse], each item withpath,unknown_in(the ends of the range wherecheck_symbolsreads the pathunknown) andhint— the same reasoncheck_symbolsgives, not a second derivation of it.notegains a sentence pointing at that field, so a reader who only looks ateventsisn't misled: one path names itself, several are shown three at a time with a count, like_never_seen_note.never_seenandsuppressedkeep their current meaning, so the change is additive and no renamed or removed field.A path is left out of
unchecked_useswhen:never_seenalready covers it (it ismissingat one end, and that list says which end), so the same fact isn't stated twice;affectsalready takes it (the removal is the answer, e.g.langgraph 0.0.37 -> 0.3.31withcheckpoint.memory.InMemorySaver);check_symbolshas the path at both ends.Evidence, on the published index
uv run deptime index pull, then the issue's example. Before this branch:{"package":"langgraph","from_version":"1.0.2","to_version":"0.2.39","events":[],"truncated":false,"suppressed":0,"never_seen":[]}After:
{ "package": "langgraph", "from_version": "1.0.2", "to_version": "0.2.39", "events": [], "truncated": false, "note": "`langgraph.checkpoint.base.get_checkpoint_metadata` can't be checked: the index can't tell what langgraph has at 1.0.2 or 0.2.39, so no event can say whether the name survived (`unchecked_uses` says why).", "suppressed": 0, "never_seen": [], "unchecked_uses": [{ "path": "langgraph.checkpoint.base.get_checkpoint_metadata", "unknown_in": ["1.0.2", "0.2.39"], "hint": "langgraph is a namespace package, and langgraph 1.0.2 requires langgraph-checkpoint, langgraph-prebuilt and langgraph-sdk, which can install modules into it; langgraph itself doesn't have this one" }] }Going the other way,
0.2.39 -> 1.0.2, reads the same withunknown_inreversed. Andnever_seenstill answers where it does:Tests
Two tests in
tests/test_query.py, on the syntheticngindex:test_diff_lists_a_used_path_check_symbols_cant_check_with_the_reason— a namespace package that requires a distribution which can install into it: the path isunknownat both ends and lands inunchecked_useswithng-checkpointin the hint and in the note; a name the index has at both ends, and a call withoutused_symbols, list nothing; a module the package owns at thefromend and another distribution fills at thetoend isunknownat that end only, and the note names that end rather than the whole range.test_a_used_path_missing_at_one_end_is_left_to_never_seen— theInMemorySavershape above:never_seenhas it,unchecked_usesdoesn't.Run against the source with the tests kept, both fail with
AttributeError: 'DiffResult' object has no attribute 'unchecked_uses'; with the models andquery.pyin place they pass.Checks
No
bench/touched, as the issue asked.