Repository navigation
feat(diff): say which used names are deprecated where you're going (DT-CORE-62) - #24
Closed
rise11hx-cmyk wants to merge 1 commit into
Closed
rise11hx-cmyk wants to merge 1 commit into
rise11hx-cmyk wants to merge 1 commit into
Conversation
diff_versions answers with used_symbols, so it should answer for the version the code is going to: a path already deprecated there is listed in deprecated_uses with deprecated_in and the library's message, wherever the deprecation began. A deprecated event inside the range stays, and says when the deprecation ended in detail.until; a removal doesn't count as an end, it has its own event (DT-CORE-62).
Contributor
Author
|
"A parallel run of mine opened #23 for the same issue while this branch was in flight, so this one is a duplicate: closing it to leave one PR on #15. Everything below is in #23 as well, including both halves of your reply and the three index cases.\n\nThe only extra here is documentation, not behaviour, and #23 can take it in a follow-up if you want it: a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
diff_versionswithused_symbolsanswers about a range, but what a reader acts on is the state atto_version. A used path already deprecated there is now listed indeprecated_uses, next tonever_seenandunchecked_uses, withdeprecated_inand the library's message, wherever the deprecation began. Adeprecatedevent inside the range stays as it is, and carriesdetail.until— the first release where the name is still there but no longer deprecated — when the deprecation ends beforeto_version. A removal isn't an end: it has its own event.The four cases, on the index
langgraph.errors.NodeInterrupt,1.0.2 -> 1.2.20(deprecated from 0.6.0, no event in the range):huggingface_hub.Repository,0.32.2 -> 0.23.2(both ends deprecated; the text moved from the class to its own__init__at 0.20, and_check_symbolsalready reads that as the class's):gradio.update,3.23.0 -> 6.31.0(deprecated at 3.45.0, no longer deprecated at 3.48.0): not listed, and the event says where it ended.Shape
_unchecked_usesand_deprecated_usesnow read the same_check_symbolsresult at each end of the range, taken once per used path instead of twice.detail.untilis computed at answer time (_deprecation_until), so no ingest change and no new index format; it reads a class's__init__deprecation as the class's, and skips releases where the name is gone.Gates
models.py/query.pyreverted and the two new tests kept,AttributeError: 'DiffResult' object has no attribute 'deprecated_uses'; with the code, both pass.ruff format --check/ruff checkclean; full suite 592 passed, with only the two tests that needgiton this Windows box failing for a missing shell (COMSPEC), as they did before this branch.bench/curated_check.py: 401 hints, 0 problems.