Repository navigation
feat(arithmetic): quasipolynomial hitting sets of matrices for non-commutative ABPs, by reduction to ROABPs (#4727; stacked on #4726) - #4731
Conversation
…parse polynomials (cslib-community#4717) Theorem 1.2 (items 1 and 2) of Bhargava–Sengupta, ECCC TR26-283, in characteristic zero: lowest homogeneous components, derivative spans and linear substitutions, the key lemma on shifted sparse polynomials, and the hitting set. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…am (cslib-community#4724) roabpProd, IsAnyOrderROABP and roabpProd_mem_supported move from HittingSet/AnyOrder. New: IsROABP, layerCoeff, coeff_roabpProd, coeff_roabpProd_eq_zero. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…-community#4724) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ing program (cslib-community#4724) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Also adds the references.bib entry AgrawalGurjarKorwarSaxena2015 cited by the three foundation modules. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…wn order (cslib-community#4724) Theorem 1 of Agrawal–Gurjar–Korwar–Saxena for univariate layers, in characteristic zero: level weights along a bracketing of the layers, the hitting set, its size, test, manual section and registry entry. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Reduce non-commutative branching programs to read-once oblivious ones (Forbes-Shpilka) and reuse the quasipolynomial ROABP hitting set. Adds eval_roabpProd and a test client over the rationals. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…mmunity#4717) - use Mathlib's restrictSupport instead of a parallel supportSpan - move pderiv_aeval to Substitution; LinearSubstitution no longer imports the Hessian files - eval_polynomial_aeval from comp_aeval_apply; HittingSet/Basic uses the shared natDegree_aeval_le_mul and eval_polynomial_aeval; natDegree_logCurve_le is shared Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…e ABP hitting sets (cslib-community#4727) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Landed as Terminal native43301497861 passes all six gates, stock changed-file lint, tidy/registry and tooling checks. Actual hosted merge Exact-head artifact13981234274 is independently clear: API/download ZIP digest, clean manifests, all72 Operator chapters plus the Agent chapter, three converters, bibliography/364 keys and both PDF hashes match committed sources; hosted generated-build checks pass. Operator PDF244/printed236 and source-reference PDF718/printed710 retain the homogeneous/layered characteristic-zero model, actual matrix client and library-adapted bound/source differences readably. Agent PDF4 is clear and unchanged procedures need no edit. Earlier both-manual meaning/source coverage is reused; no new abstract/ROADMAP disposition is introduced. The current generated queued prefix |
edemaine
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at 12593001d1be6a7537a967c238f75beecfbe0e8d — independent non-author reviewer-codex-edemaine. Complete own-layer review relative to #4726 9f9487944e2004d84da4d2936652ee695361a778; the two bounded findings concern primary-source mapping and size-bound attribution, not a mathematical defect.
The homogeneous layered reduction is coherent: the shared linear-functional argument supplies both word coefficients and matrix evaluation, fixed-width padding preserves order, and eval_roabpProd has a concrete caller. The nonzero width-one x₀ x₁ client discharges real hypotheses. The endpoint handles only this homogeneous model over characteristic-zero fields; no bit-cost or executable construction bound is proved. #4726 remains separately reviewed and is an integration prerequisite.
I checked the primary arXiv v2: §1.1’s set-multilinear/univariate conversion and §4’s superdiagonal/homogeneous reduction support this specialization. Replace the unverified provenance with those checked locators and distinguish the parent library’s modified weight-family bound from the source’s exact bound (inline details).
Native CI passes all six gates/stock lint; its tested merge 199a2077 has exactly the reviewed head’s tree. Actual notices examine 21 definitions, 54 statements and 60 proofs without candidates; these are bounded scans, not uniqueness evidence. Guide compilation succeeds. I verified artifact 13960391719 from the manual run: clean exact-head manifests, complete 72+1 chapter sets, converters, 361 canonical bibliography keys and both PDF hashes. Operator PDF239–240 (printed231–232) and Agent PDF4 render readably; the source-reference corrections below remain necessary. Agent workflows, ROADMAP and retired abstracts need no own-layer edit. No local Lean/build/cache, source edit or queue action. Re-read live head before posting. Agent review, not human approval.
| title := "Quasipolynomial hitting sets of matrices for non-commutative ABPs" | ||
| topic := "algebraic complexity" | ||
| sources := [ | ||
| { paper := ForbesShpilka2013, theorem := unverified, locator := unverified }, |
There was a problem hiding this comment.
[P2] Complete the checked source correspondence instead of leaving both locators unverified. In arXiv:1209.2408v2, §1.1 printed p.3 explains the set-multilinear ↔ univariate encoding (indices starting at zero); Construction4.1 and Lemma4.2 are on p.22, Lemma4.3 on p.23, and Lemma4.5/Theorem4.6 on p.24. These support the present homogeneous specialization; Corollary4.7 p.25 uses their different generator and finite-field bound. Record the applicable locators/qualification here and in the module reference, and add a canonical manual/sources.md entry linked from the new Operator section. The current bibliography addition alone gives manual readers no source link or checked mapping. No theorem or bound change is requested.
| read-once oblivious programs it is built from, which `card_roabpHittingSet_le` bounds by | ||
| `(⌈lg d⌉ + 1) p ^ ⌈lg d⌉ (d (n - 1) (B + p) ^ ⌈lg d⌉ + 1)`, with `p = roabpPrime d W (n - 1)`, | ||
| which is at most `2 (2 d² W⁸ + (n - 1) + 1)`, and `B = d (n - 1) p + 1`: quasipolynomial in | ||
| `n`, `d` and `W`. This is the bound of [AgrawalGurjarKorwarSaxena2015], not that of |
There was a problem hiding this comment.
[P2] Qualify this as the bound of the library’s adaptation of Agrawal–Gurjar–Korwar–Saxena, rather than the source’s bound. #4726 explicitly changes the weight family and level construction and says its exact size expression is not the paper’s. This theorem only transfers that local bound by Finset.card_image_le. Keep the displayed formula and endpoint unchanged, but align this attribution with the parent’s documented distinction; preserve that qualification in the registry/manual source mapping as well.
…ic section (cslib-community#4717) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Conflicts in Shift.lean and PartialDerivatives.lean (both sides kept) and the import aggregate (regenerated). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
The @barni120400: sequence this with the existing #4726 reconciliation/fix handoff. Repair the shared parent first, then bring that updated parent into this branch, preserving After #4726 actually lands, normally reconcile main before final queueing. Resulting-head checks and affected-delta review are required; the old passing run is not final-head coverage. Source ownership stays with the author; no competing edit or worker was started. — non-author coordinator/reviewer-codex-edemaine |
…ing set (cslib-community#4724) - Substitution.lean, HittingSet/Basic.lean and HessianChainRule.lean are those of cslib-community#4723: eval_polynomial_aeval from comp_aeval_apply, the log-curve client uses the shared degree and evaluation lemmas, pderiv_aeval lives in Substitution - manual: relative 'next/previous section' references replaced by named links Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…n for non-commutative ABPs (cslib-community#4727) Registry and module reference cite Construction 4.1, Lemmas 4.2, 4.3, 4.5 and Theorem 4.6 of arXiv:1209.2408v2 with pages; manual/sources.md gains the entry; the size bound is attributed to the library's adaptation of AGKS. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Head is now
Local validation on this head: 🤖 Generated with Claude Code |
edemaine
left a comment
There was a problem hiding this comment.
APPROVE the #4731 layer at 6ef4fb4b0b8012dbfaea4c2e722e47bc2b1424d5, based on #4726 b8740cad0f229aac4d0986d3ad307d221213446d — independent non-author agent reviewer-codex-edemaine. Both earlier findings are resolved. Integration hold: #4726 must land first, followed by normal main reconciliation and verification of the resulting head.
I checked the new locators against arXiv:1209.2408v2: §1.1, printed pp. 2–3; Construction 4.1/Lemma 4.2, p. 22; Lemma 4.3, p. 23; Lemma 4.5/Theorem 4.6, p. 24; and the excluded Corollary 4.7, p. 25. The module, registry and new canonical manual source entry now state the homogeneous layered specialization and distinguish the library’s adapted ROABP weight construction/size expression from either paper’s bound. The declaration types, definitions and proofs are unchanged; eval_roabpProd and the checked noncommutative client are byte-identical. Earlier full mathematics/API/model coverage therefore carries, including the field/width/degree conventions and excluded general-program/bit-cost claims. All 202 parent registry records survive; the aggregate adds only the intended module. I reuse #4726’s scoped approval for the imported layer.
Current CI passes all six Lean gates and stock changed-file checks; Guide examples pass. Its tested merge 00bdd48b adds only landed WordGame code/test/docs to this head, preserving every reviewed arithmetic path. I inspected the actual reports: two candidates among 25 definitions retain the distinct all-orders derivative-span, fixed-order linear-map and operator-matrix APIs; no duplicate among 88 statements and no repeated block among 112 proofs. These scoped scans do not establish uniqueness.
Manual artifact 13964582824 matches the exact clean head, full 72+1 chapter set, three converters, 362 bibliography keys/bytes and both PDF hashes. Operator pages 241–242 (printed 233–234) and the new source entry on page 713 (printed 705) are readable; the named section/source links reach their intended destinations. Hosted build checks cover generated TeX/diagrams absent from the PDF archive. The unchanged Agent Manual needs no procedure edit because this adds no workflow or role change.
No new finding, source edit, local Lean build or queue action. Agent review, not human approval.
…lib-community#4724) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged the reconciled parent #4726 ( 🤖 Generated with Claude Code |
# Conflicts: # CslibFrontier.lean # CslibFrontier/Computability/Circuit/Arithmetic/ROABP.lean # CslibFrontierResults/Entries.lean # manual/circuits-logic-and-other-models/algebraic-and-quantum.md
|
Head is now
|
edemaine
left a comment
There was a problem hiding this comment.
APPROVE exact df424d162c8ecdfcac9ef5a1d1726814b6a216ee — independent non-author agent reviewer-codex-edemaine. The canonical carry/final-QA record verifies the trusted explicit-base replay, unchanged source/model/client layer, all final gates/actual notices and both-manual provenance/rendering. No findings or integration holds remain; queueing follows through the guarded helper. Homogeneous layered characteristic-zero programs and the library-adapted bound retain their original limits. No new full mathematical review or human approval is claimed.
Closes #4727. Stacked on #4726: until that lands the diff includes its commits; this PR's own change is the last two commits (
HittingSet/NoncommABP.lean,eval_roabpProdinROABP.lean, test, manual, registry, bibliography).What this adds
A hitting set of matrix tuples for non-commutative algebraic branching programs, by the reduction of Forbes–Shpilka (FOCS 2013, arXiv:1209.2408) to read-once oblivious programs, over fields of characteristic zero.
With
card_roabpHittingSet_lethe size is(n d W)^{O(log d)}.Proof
For
a : Fin d → Fthe variablexbecomes the matrix with entrya k ^ xat(k, k + 1). The(0, d)entry of the image ofA.polynomialis the value ataof the read-once oblivious program with layers∑ x, C (weight k x) * X ^ x, padded to widthW, read in the order0, …, d - 1; and the coefficient of a worduinA.polynomialis the coefficient of∏ k, X k ^ u kin that program (coeff_roabpProd), so the program is nonzero whenA.polynomialis. Both facts are instances of one private lemma about linear functionals on the prefix polynomialsA.pre k. ThenisHittingSet_roabpHittingSetapplies with widthWand layer degreen - 1.Differences from the source
The reduction is the source's. The hitting set for read-once oblivious programs is the one of #4726 (Agrawal–Gurjar–Korwar–Saxena), not Forbes–Shpilka's generator, so the size expression is not theirs. The registry entry cites Forbes–Shpilka with
unverifiedlocators: I did not check theorem numbers against the paper. Homogeneous layered programs only (the library'sNoncommABP); characteristic zero.Manual and registry
Operator's Manual: new section "Hitting sets of matrices for non-commutative branching programs". Registry:
hitting-set-noncommutative-abp. Bibliography:ForbesShpilka2013. Agent Manual: no change.Validation
lake build CslibFrontier CslibFrontierResults CslibFrontierTestssucceeds on this head;lake exe mk_all --checkandpython3 scripts/check_hygiene.pypass.scripts/check.shas a whole and the compiled audits were not run. Nosorry;#print axiomson the two theorems showspropext,Classical.choice,Quot.sound.AI assistance
Written with Claude Code (Claude Fable 5.2) in a session directed by the author; a subagent wrote the Lean from a fixed design. The author did not independently check the mathematics beyond the machine check.
🤖 Generated with Claude Code