Repository navigation
feat(arithmetic): hardness gives hitting sets for constant-depth formulas — Reed–Solomon designs, Nisan–Wigderson generator, hybrid argument (#4734, milestone 3; stacked on #4745) - #4746
Conversation
…equation (cslib-community#4734) Universal root by a Newton step on the order of vanishing, uniqueness of a root to a given order, and the structure theorem f = α + (A(gᵢ - gᵢ(0)))_{≤ d+1}; reduction of an arbitrary root to a simple one in characteristic zero. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…formulas Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…al; roots by a closed formula (cslib-community#4734) A finite proof of the Lagrange inversion formula modulo powers of an ideal (telescoping and a weight filtration, no power series), and the resulting formula for the low-degree part of a root of a polynomial equation. Replaces the Newton-iteration structure theorem of the previous commit. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…of product-depth Δ + 1 Implements BhattacharjeeEtAl2025, Theorem 4.1, from the closed formula MvPolynomial.exists_shift_eq_truncate_sum_of_root: derivative via interpolation in a new variable, shifts by affine inputs, one layer of powers, coefficients and truncation by interpolation. Size bound rootCost s D = 2^36 (s+1)^8 (D+1)^6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nt for formulas Partial evaluation of polynomials over infinite domains and the monomial count of a partially specialized multilinear polynomial; the generator, the hybrid argument producing a formula of product-depth Delta + 1 with f as a root in its last variable, and the grid hitting set. References KabanetsImpagliazzo2004 and DvirShpilkaYehudayoff2009 added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sets for constant-depth formulas (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Landed: exact reviewed APPROVE at I independently reran current main’s trusted checker (blob All16 retained M2/M3 library/test files, the additional Current manual43319804702/artifact13990380968 independently passes exact-clean-head QA: API/download digest, both manifests, complete72+1 chapter set, all77 source/converter/bibliography inputs,364 ordered bibliography keys and both PDF hashes; both hosted Terminal native43319804678/job131537365339 passes all six gates, stock changed-file lint, tidy/registry, hygiene and tooling checks. Current full Guide43319804684 passes. I read the actual complete final notices: no candidate among5 changed public definitions,22 statements or24 proofs, with no reported incomplete comparison. These bounded scans supplement the retained source/API review, not a uniqueness claim. Actual tested merge This root non-author Actual landing remains pending under the existing watch. #4734 stays open; #4780 must wait for this milestone’s actual landing and any necessary normal-main reconciliation, carry and current validation. This remains the finite conditional M3 result, with no new family/runtime/bit-cost claim. No source edits, local Lean/build/cache/compiled-output probe, new worktree or duplicate full mathematical review. Agent review/integration, not human approval. |
edemaine
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at 3a6907fe40e2128c2074eff4fcdc7bba51b6104a — independent non-author agent /root/review4746_hardness_generator, for coordinator/reviewer-codex-edemaine. Three bounded reuse/manual repairs are inline. I found no mathematical defect in this complete own layer relative to #4745 b9b1c22bed3ded879e92874b6aba46c3886a926a; the lower root/formula proofs have separate reviews.
The finite theorem takes one multilinear hard polynomial and supplied block embeddings with intersection bound a. The hybrid keeps a nonzero polynomial after constant specialization; earlier blocks use at most 2^a monomials, giving the stated substitution size and one additional product layer. The lower root theorem supplies the second layer and rootCost; the nonvanishing branch uses the degree-bounded grid. The prime/m ≤ q hypotheses make the design’s first coordinates injective; k=0, empty blocks/variables and constant-polynomial cases are consistent. Checked clients exercise an actual vanishing hybrid, nonvanishing grid and nonzero partial specialization, plus the small design. The final hard-polynomial hypothesis is intentionally not instantiated here; the asymptotic IMM application, circuits and running-time/uniformity conclusions remain outside this milestone.
I checked CKS arXiv:1803.05933v1, Lemma 7.1 and its proof on printed p. 20 and Theorem 2.3 on p. 3, against the finite hybrid/grid construction; Bhattacharjee et al. v1, Theorem 6.1 on printed p. 28, supplies the root-closure connection. The Lean formulas/product-depth and explicit finite bound are an adaptation, not those papers’ family/runtime theorems. The new KI bibliography matches the publisher; the DSY metadata matches its publisher.
Current Guide passes. At the last meaningful read, native CI had passed strict library/tests and was running lint: remaining gates and compiled definition/statement notices were not final. The source proof-notice step had completed, but its report contents were unavailable from the running-job API; no clean advisory claim is made. No local Lean/Lake/build/cache or compiled probe ran. Incoming main’s Code/Schöning/manual paths are blob-identical to 4bf944ae and excluded from this own-layer review.
Both manuals were assessed. The Agent Manual needs no role/procedure edit. The Operator’s new-API deferral is the third finding; a shared short reference suffices. Registry additions are nonmandatory here, and #4734’s endpoint/asymptotics remain open. No source edit, queue or human approval.
…slib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eference for formulas for roots (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on bound; Operator reference for the generator (cslib-community#4734) card_polynomialBlock_inter_le moves from the Nisan–Wigderson design module to the foundations design module, and the Reed–Solomon bound is derived from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Head is now
Local validation on this head: 🤖 Generated with Claude Code |
edemaine
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at 47bcafeae1c1184487f20c03ec7a753af5e48f68 — independent non-author agent reviewer-codex-edemaine. The three earlier findings are resolved. One bounded import-surface cleanup introduced by the shared-module migration remains inline; no new mathematical or model defect was found.
The five hybrid/grid uses now apply Mathlib’s actual comp_aeval_apply with the correct argument order, and the private duplicate is gone. The four graph declarations retain identical statements/proofs/docstrings/attributes at the lower Cslib home, with Samuel Schlesinger credited. Both Crypto consumers resolve the moved names through the foundation import; no old qualified names or aliases remain in the current tree. The restricted design uses the shared intersection theorem through the injective Fin m → ZMod q map (m ≤ q). Its explicit sum agrees with the old ofFn evaluation by ofFn_eq_sum_monomial; the cardinality and zero-size reasoning remain valid. The endpoint, partial-evaluation module and both checked clients are unchanged.
The trusted explicit-base checker passes for the old layer replayed onto updated #4745 at merge d841b2dd; the subsequent reviewed return changes exactly NWGenerator, Crypto/Design, ReedSolomon and the arithmetic manual. Earlier full mathematical/primary-source coverage is reused. The new Operator section correctly states the multilinearity/degree/block/hardness/CharZero contract, image/cardinality bound, clients and absence of an instantiated hard family or runtime theorem. No changed abstract, registry or ROADMAP disposition is needed; #4734 remains open.
Artifact13976667373 matches its API/ZIP digest, exact clean-head manifests, complete72+1 chapters, three converters, bibliography/363 keys and both PDF hashes. Operator PDF244–245 (printed236–237) and Agent4 are readable; Agent procedures need no edit. Guide compilation/site build succeeds; no separate visual HTML claim is made.
At the final validation read, native CI passed strict build/tests and was running lint. Later gates/stock/tidy checks and actual current notices remain pending. Lower-layer landing and resulting-main coverage also remain integration holds. Please return the import-only fix with affected callers checked; no repeat full mathematical review is needed. No source edits, local Lean/build/cache probes or queue action. Agent review, not human approval.
The polynomial API is used only in the proof of card_polynomialBlock_inter_le, so its imports are plain; Polynomial.OfFn is no longer used. The test imports the vector notation it uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CslibFrontier.lean
|
Head is now
|
# Conflicts: # manual/circuits-logic-and-other-models/algebraic-and-quantum.md
|
Head is now
|
edemaine
left a comment
There was a problem hiding this comment.
APPROVE the bounded import/test repair and verified carry at 8eb64d9561a97455a0b5f59f9e31607f7e4a6b7c, relative to #4745 facf2430a6c09cd29e5f51409739bffee2043ac2 — independent non-author agent reviewer-codex-edemaine. The canonical review verifies the import cleanup, unchanged real test, both trusted replay checks and current manual QA. This clears this reviewer’s obsolete import change request. Current native gates/actual notices and #4745 actual landing/reconciliation remain holds; do not queue yet. No source edits or local builds. Agent review, not human approval.
# Conflicts: # CslibFrontier.lean
|
Head is now
|
# Conflicts: # manual/circuits-logic-and-other-models/algebraic-and-quantum.md
|
#4745 has landed as |
|
Head is now
|
edemaine
left a comment
There was a problem hiding this comment.
Independent non-author agent APPROVE exact 67b7f54d7ab3bd10334db6fdc4420ad4c1300e45 — reviewer-codex-edemaine. The retained mathematical/import-test review, independently rerun exact carry, current six gates and actual notices, Guide and exact-head both-manual QA are clear. Trusted explicit-base replay passes after #4745’s actual landing; statements, imports/exposure, actual Crypto/design/generator/root clients and complete own manual chapter preserve checked identity. Final tested merge has exactly this head’s tree. This is the finite conditional hardness-to-hitting-set milestone, with no new family, compiler-runtime or bit-cost claim. No findings or extra full mathematical audit. Agent review, not human approval; proceeding through the guarded queue helper after a clean full generated-prefix check.
…ulas from the LST lower bound (cslib-community#4734, milestone 4; stacked on cslib-community#4746) (cslib-community#4780) * feat(foundations): the structure of low-degree roots of a polynomial equation (cslib-community#4734) Universal root by a Newton step on the order of vanishing, uniqueness of a root to a given order, and the structure theorem f = α + (A(gᵢ - gᵢ(0)))_{≤ d+1}; reduction of an arbitrary root to a simple one in characteristic zero. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * doc(references): Chou, Kumar and Solomon on closure under factorization Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(arithmetic): substitution and interpolation of unbounded fan-in formulas Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(combinatorics): Reed-Solomon designs Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(foundations): Lagrange inversion for a fixed point of a polynomial; roots by a closed formula (cslib-community#4734) A finite proof of the Lagrange inversion formula modulo powers of an ideal (telescoping and a weight filtration, no power series), and the resulting formula for the low-degree part of a root of a polynomial equation. Replaces the Newton-iteration structure theorem of the previous commit. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(arithmetic): roots of formulas of product-depth Δ have formulas of product-depth Δ + 1 Implements BhattacharjeeEtAl2025, Theorem 4.1, from the closed formula MvPolynomial.exists_shift_eq_truncate_sum_of_root: derivative via interpolation in a new variable, shifts by affine inputs, one layer of powers, coefficients and truncation by interpolation. Size bound rootCost s D = 2^36 (s+1)^8 (D+1)^6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): the Nisan-Wigderson generator and the hybrid argument for formulas Partial evaluation of polynomials over infinite domains and the monomial count of a partially specialized multilinear polynomial; the generator, the hybrid argument producing a formula of product-depth Delta + 1 with f as a root in its last variable, and the grid hitting set. References KabanetsImpagliazzo2004 and DvirShpilkaYehudayoff2009 added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): the superpolynomial IMM lower bound for constant-depth formulas (cslib-community#4734) SPFormula.eventually_pow_lt_nodeCount_of_imm; the circuit form is now derived from it instead of repeating the argument. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): hardness of a multilinear polynomial gives hitting sets for constant-depth formulas (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): subexponential hitting sets for constant-depth formulas Limaye-Srinivasan-Tavenas Corollary 6 via Chou-Kumar-Solomon Theorem 2.3: over a field of characteristic zero, for all large n, constantDepthHittingSet K c t n hits every nonzero polynomial computed by a formula of product-depth at most Δ with at most n ^ c nodes, has at most 2 ^ (n ^ (1 / t)) points, and (at exponent (c + 2)(2Δ + 1)) hits simple circuits of product-depth Δ with at most n ^ c gates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): subexponential hitting sets for constant-depth formulas from the LST lower bound (cslib-community#4734) Instantiation of the hardness-to-hitting-set theorem with IMM and the formula form of the LST lower bound; manual section and registry entry. The set-multilinear degree facts move to the foundations module, and the growth lemma is shared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: reuse coeff_zero_shift; shared Operator reference for roots (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: shared degree-of-substitution bound over algebras; Operator reference for formulas for roots (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: reuse comp_aeval_apply; share the polynomial-graph intersection bound; Operator reference for the generator (cslib-community#4734) card_polynomialBlock_inter_le moves from the Nisan–Wigderson design module to the foundations design module, and the Reed–Solomon bound is derived from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * doc: rewrap a docstring paragraph (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: real-ε endpoint, a nonvacuous client, corrected source attributions and manual placement (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(foundations): private polynomial imports in ReedSolomon The polynomial API is used only in the proof of card_polynomialBlock_inter_le, so its imports are plain; Polynomial.OfFn is no longer used. The test imports the vector notation it uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Part of #4734 (milestone 3 of 4). Stacked on #4745 (and through it #4739): until those land, the diff also shows their modules.
What this adds
Hardness of a multilinear polynomial gives explicit hitting sets for constant-depth formulas — the Kabanets–Impagliazzo theorem for formulas of bounded product-depth, over fields of characteristic zero, with explicit parameters.
generatorHittingSet f S Dis the set of values of the Nisan–Wigderson generatornwGenerator f S i = rename (S i) fon the grid{0, …, D} ^ L.Parts
Foundations/Combinatorics/Design/ReedSolomon.leanIsDesign,rsDesign q m k(graphs of theq ^ kpolynomials of degree< koverZMod qonm ≤ qpoints),isDesign_rsDesign: pairwise intersections≤ k − 1.Foundations/Data/MvPolynomial/PartialEval.leanexists_aeval_sumElim_ne_zero: over an infinite domain, a nonzero polynomial stays nonzero after assigning constants to some variables. Support and degree bounds for substituting variables and constants into a multilinear polynomial (at most `2 ^HittingSet/NWGenerator.leannwGenerator; the hybrid argumentexists_root_formula_of_generator_vanishing; the grid lemma andgeneratorHittingSet.HittingSet/HardnessToHittingSet.leanProof
Let
Chave a nonzero polynomial. IfC ∘ nwGeneratoris nonzero, Schwartz–Zippel on the grid gives a point (its degree is at mostnodeCount C · d). Otherwise the hybridsH_i(the firstiinputs replaced by the generator) give an index withH_i ≠ 0,H_{i+1} = 0. Fixing every variable outside blockiand inputito constants that keepH_inonzero makes each earlier generator input a multilinear polynomial in the at mostavariables its block shares with blocki, so a depth-1 formula of at most2 ^ a (a + 1) + 1nodes. This yields a nonzero formula of product-depthΔ + 1in the block variables andywith rootf. The root theorem of #4745 (SPFormula.exists_formula_of_root) turns it into a formula forfof product-depthΔ + 2and at mostrootCost (s (2 ^ a (a + 1) + 2)) dnodes, contradicting hardness.Sources and departures
+2here (one for the restricted generators, one for the root) against the sources'+O(1).Cslib.Crypto.PRG.NisanWigderson.Designis a bundled structure of a different shape, so it is not reused; the module docstring says so.Manual and registry
The Operator’s Manual extends the shared “Roots of polynomial equations and hardness versus randomness” section with the generator/design imports, finite multilinearity/degree/block/hardness/characteristic-zero assumptions, image/cardinality contract, complete hybrid/grid/design clients and repository-root build command. It explicitly leaves the hard-family instantiation and runtime theorem to later work. The Agent Operator’s Manual needs no edit because roles and procedures are unchanged. No registry entry is added for this intermediate finite theorem; milestone4 is its intended endpoint client. The full #4734 objective remains open.
Validation
Local checks reported at this head:
lake build CslibFrontier CslibFrontierResults CslibFrontierTestssucceeds;check_hygiene.pyandcheck_changed_files.py --base origin/mainpass;audit_queries.py duplicatesonComputability/Circuit/Arithmetic/andFoundations/finds no group containing these modules;references --unusedlists only the endpoint above and thesimplemmanwGenerator_apply.scripts/check.shas a whole was not run. Nosorry. Tests:nwGeneratorand the grid lemma onX 0, the hybrid lemma onx₀ − x₁with two copies of a block (a = 1), the specialization lemma onx₀ y₀, and a Reed–Solomon designIsDesign (rsDesign 3 2 2) 2 1.Hosted current-head validation: all six gates, stock/tidy/registry checks, actual notices, Guide compilation/site build and both-manual provenance/render review are clear. Canonical independent review and remaining source hold. One import-surface cleanup still requires an author return and affected-delta review; lower-layer landing/reconciliation also holds integration. This does not claim a new local whole-library run.
AI assistance
Written with Claude Code in a session directed by the author; subagents wrote the designs, the specialization lemmas and the generator modules from a fixed design. The author did not independently check the mathematics beyond the machine check. The bibliography entries
KabanetsImpagliazzo2004andDvirShpilkaYehudayoff2009were written from memory and should be checked.🤖 Generated with Claude Code