Repository navigation
feat(arithmetic): roots of constant-depth formulas have constant-depth formulas — formula substitution, interpolation, root construction (#4734, milestone 2; stacked on #4739) - #4745
Conversation
…equation (cslib-community#4734) Universal root by a Newton step on the order of vanishing, uniqueness of a root to a given order, and the structure theorem f = α + (A(gᵢ - gᵢ(0)))_{≤ d+1}; reduction of an arbitrary root to a simple one in characteristic zero. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…formulas Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…al; roots by a closed formula (cslib-community#4734) A finite proof of the Lagrange inversion formula modulo powers of an ideal (telescoping and a weight filtration, no power series), and the resulting formula for the low-degree part of a root of a polynomial equation. Replaces the Newton-iteration structure theorem of the previous commit. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…of product-depth Δ + 1 Implements BhattacharjeeEtAl2025, Theorem 4.1, from the closed formula MvPolynomial.exists_shift_eq_truncate_sum_of_root: derivative via interpolation in a new variable, shifts by affine inputs, one layer of powers, coefficients and truncation by interpolation. Size bound rootCost s D = 2^36 (s+1)^8 (D+1)^6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Landed as I independently reran current main's trusted checker with approved Exact-head artifact13982124277 is independently verified: API/ZIP digest, clean manifests, complete72+1 chapters, three converters, bibliography/363 keys and both PDF hashes match committed sources; both hosted build/source checks pass. Operator PDF245–246/printed237–238 is readable, preserving the finite Lagrange/root hypotheses, contracts and client commands. Agent PDF4 is clear with unchanged source/procedures. Earlier both-manual meaning coverage carries; no ROADMAP/results/abstract change is needed. Current Guide43303902344 and manual43303902109 pass. Terminal native43303902223 passes all six gates, stock changed-file lint, tidy/registry and tooling checks. I read the complete actual notices: no candidate among7 definitions,38 statements or42 proofs. These bounded reports supplement the retained mathematical/API review; they do not establish uniqueness. Actual tested merge I reran the trusted explicit-base checker before integration: PASS. All nine own library/test files are also byte-identical to reviewed This non-author coordinator/reviewer-codex-edemaine session (GitHub |
edemaine
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at b9b1c22bed3ded879e92874b6aba46c3886a926a — independent non-author agent /root/review4745_root_formula, for coordinator/reviewer-codex-edemaine. Complete own-layer review relative to #4739 2d57804d8421fae0b4c624db9c3b68ca2723599a; the lower algebra proof has its separate review. The two inline findings concern shared degree-bound reuse and the missing usable Operator reference, not a mathematical counterexample.
I read all four new library modules and four tests, the actual parent root interface and existing formula/interpolation APIs. The construction’s accounting checks out: derivatives come from Taylor coefficients with a factorial scalar; affine substitution and interpolation preserve product-depth, powers add one product layer, and the displayed node-count estimates imply the stated 2^36 (s+1)^8 (D+1)^6 bound. The nonzero-polynomial/root hypotheses are meaningful, and the y-x₀x₁ client instantiates them. This is polynomial-root existence for formulas in characteristic zero, with product-depth and node count; it supplies neither general factor closure, an algorithm nor bit-cost bounds.
The primary-source map is coherent: Bhattacharjee et al., arXiv:2506.23214v1, §4.1 Theorem 4.1 (printed pp. 19–20), gives the simple-root/truncation complexity argument; the parent supplies the derivative/shift reduction for arbitrary polynomial roots. Chou–Kumar–Solomon, arXiv:1803.05933v1, §4.6 Lemmas 4.10–4.11 (printed p. 10), supplies the coefficient-interpolation argument. The stronger explicit product-depth/node-count conventions are proved here rather than attributed as the papers’ literal bounds. Source credit and the non-exhaustive registry/ROADMAP assessment are appropriate; no changed formal abstract.
Current native CI passes all six gates and stock changed-file checks; Guide passes. The tested merge 649288fa preserves every own library/test path, with additional unrelated incoming main changes. I read the actual reports: no parallel candidate among 8 definitions, duplicate statement among 53 theorems, or repeated block among 53 proofs. These bounded scans miss specializations and inline re-derivations, including the first finding.
Both manuals were assessed against exact-head source. Extend the single shared Operator reference being requested in the lower milestone, rather than creating a separate tutorial or waiting for milestone 4. The Agent Manual needs no edit because roles and procedures are unchanged. No new manual pages were rendered: the PR changes no manual source, and that missing reference is a requested repair. No source edits, local Lean/Lake/build/cache or compiled probes, approval or queue action. Agent review, not human review.
…slib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eference for formulas for roots (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Head is now
Local validation on this head: 🤖 Generated with Claude Code |
edemaine
left a comment
There was a problem hiding this comment.
APPROVE the own-layer source/manual delta at d68cd8b16c102ec522878810e740d49dc3107267, relative to #4739 b6470324e5adc5adf865b454bf63488aa839e42b — independent non-author agent reviewer-codex-edemaine. Both earlier findings are resolved.
The generalized natDegree_aeval_le_mul needs only a commutative R-algebra: mapped coefficients remain constant, and the same product/support bounds prove the inequality. Its existing Basic/SparseOrbit uses retain the self-algebra instance. The private last-variable bound now specializes it at degree one; I checked polynomial_coeffLast_nodeCount and its derivative/root use. Statements and imports in RootFormula are unchanged; the other seven own library/test files are byte-identical. The trusted explicit-base replay of the previously reviewed layer onto the new parent passes at merge dc29f961; the subsequent reviewed fix changes exactly Substitution, RootFormula and the arithmetic manual. Earlier full mathematics/primary-source coverage is reused, not repeated.
The shared Operator reference correctly explains the last-variable/root/nonzero/characteristic-zero contract, product-depth Δ+1, exact rootCost, operations/interpolation and complete clients. It disclaims general factors, circuit/depth, algorithm and bit-cost claims. Artifact13976751181 matches the exact clean head, API/ZIP digest, complete72+1 chapters, three converters, bibliography/363 keys and both PDF hashes. Operator PDF244 (printed236) and Agent4 are readable; no Agent procedure edit is needed. Guide examples pass; rendered HTML was skipped. Abstract/registry/ROADMAP/upstream assessments remain unchanged.
Integration holds: #4739 must land, followed by normal-main reconciliation and resulting-head coverage. Current native CI passes strict build/tests/lint and is running tidy; later gates/stock checks and actual current advisories remain pending. Successful notice-step status is not inspected output. No source edits, local Lean/build/cache probes or queue action. Agent review, not human approval.
# Conflicts: # manual/circuits-logic-and-other-models/algebraic-and-quantum.md
|
Head is now
|
edemaine
left a comment
There was a problem hiding this comment.
Carry APPROVE exact facf2430a6c09cd29e5f51409739bffee2043ac2 — independent non-author reviewer-codex-edemaine. The final source/carry/validation/manual record reruns the trusted explicit-base replay, verifies all nine own library/test identities and clears current six gates, actual reports and both manuals. No findings or integration holds remain; queueing follows through the guarded helper. This reuses the full mathematical/API review and is agent carry review, not an additional approval-count requirement or human approval.
…ulas — Reed–Solomon designs, Nisan–Wigderson generator, hybrid argument (cslib-community#4734, milestone 3; stacked on cslib-community#4745) (cslib-community#4746) * feat(foundations): the structure of low-degree roots of a polynomial equation (cslib-community#4734) Universal root by a Newton step on the order of vanishing, uniqueness of a root to a given order, and the structure theorem f = α + (A(gᵢ - gᵢ(0)))_{≤ d+1}; reduction of an arbitrary root to a simple one in characteristic zero. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * doc(references): Chou, Kumar and Solomon on closure under factorization Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(arithmetic): substitution and interpolation of unbounded fan-in formulas Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(combinatorics): Reed-Solomon designs Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(foundations): Lagrange inversion for a fixed point of a polynomial; roots by a closed formula (cslib-community#4734) A finite proof of the Lagrange inversion formula modulo powers of an ideal (telescoping and a weight filtration, no power series), and the resulting formula for the low-degree part of a root of a polynomial equation. Replaces the Newton-iteration structure theorem of the previous commit. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * feat(arithmetic): roots of formulas of product-depth Δ have formulas of product-depth Δ + 1 Implements BhattacharjeeEtAl2025, Theorem 4.1, from the closed formula MvPolynomial.exists_shift_eq_truncate_sum_of_root: derivative via interpolation in a new variable, shifts by affine inputs, one layer of powers, coefficients and truncation by interpolation. Size bound rootCost s D = 2^36 (s+1)^8 (D+1)^6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): the Nisan-Wigderson generator and the hybrid argument for formulas Partial evaluation of polynomials over infinite domains and the monomial count of a partially specialized multilinear polynomial; the generator, the hybrid argument producing a formula of product-depth Delta + 1 with f as a root in its last variable, and the grid hitting set. References KabanetsImpagliazzo2004 and DvirShpilkaYehudayoff2009 added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(arithmetic): hardness of a multilinear polynomial gives hitting sets for constant-depth formulas (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: reuse coeff_zero_shift; shared Operator reference for roots (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: shared degree-of-substitution bound over algebras; Operator reference for formulas for roots (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * review: reuse comp_aeval_apply; share the polynomial-graph intersection bound; Operator reference for the generator (cslib-community#4734) card_polynomialBlock_inter_le moves from the Nisan–Wigderson design module to the foundations design module, and the Reed–Solomon bound is derived from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * doc: rewrap a docstring paragraph (cslib-community#4734) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(foundations): private polynomial imports in ReedSolomon The polynomial API is used only in the proof of card_polynomialBlock_inter_le, so its imports are plain; Polynomial.OfFn is no longer used. The test imports the vector notation it uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Part of #4734 (milestone 2 of 4). Stacked on #4739: until that lands, the diff also shows its two modules (
LagrangeInversion.lean,LowDegreeRoot.lean).What this adds
A root of a polynomial computed by an unbounded fan-in formula of product-depth
Δhas a formula of product-depthΔ + 1and polynomial size (Bhattacharjee–Kumar–Rai–Ramanathan–Saptharishi–Saraf, arXiv:2506.23214, Theorem 4.1; unrefereed), together with the formula operations it is built from.The last variable of
Fisy. The only hypotheses are characteristic zero, a nonzero polynomial and the root equation: the root may have any degree, and the size is polynomial in the size ofFand the degree off.Parts
Arithmetic/FormulaOps.leansubstFormula(substitute formulas for inputs),constInput,affineInput,ofSparse(a sparse polynomial as a formula of product-depth 1),totalDegree_polynomial_le_nodeCount; each with its polynomial, product-depth and size lemmas.Foundations/Data/Polynomial/InterpolationCoeff.leanLagrange.coeff_eq_sum_coeff_basis_smul_eval: over aK-algebra, a coefficient of a polynomial of degree `<Arithmetic/FormulaInterpolation.leancoeffLast i r F(coefficient ofy ^ i) andlowPartFormula d r F(sum of homogeneous components of degree≤ d) by interpolation, with no increase of product-depth ([ChouKumarSolomon2019], Lemmas 4.10–4.11, arXiv numbering).Arithmetic/RootFormula.leanConstruction
exists_shift_eq_truncate_sum_of_root(#4739) givesj, a pointx₀andf (x + x₀) = α + (∑_{m < 2D+2} (m+1)⁻¹ [y^m] G₀^{m+1})_{≤ D}withG₀ = y − c⁻¹ Q,Qthej-thy-derivative ofPshifted byx₀andα.∂_y^j P (x, y) = j! · [t^j] P (x, y + t), an interpolation in a new inputt.affineInput).G₀is one sum gate; each powerG₀^{m+1}is one product gate — the only extra product layer.[y^m], the truncation to degree≤ Dand the final unshift are interpolations and substitutions, with no depth.Degree bounds needed by the interpolations are always taken as the node count (
totalDegree_polynomial_le_nodeCount), so no degree bookkeeping appears.Departures
SPFormula); circuits follow throughSPCircuit.toSPFormulain milestone 4.+ O(1).rootCostis a crude closed monomial, not optimized.Manual and registry
The Operator’s Manual extends the shared “Roots of polynomial equations and hardness versus randomness” reference with the formula operations/interpolation imports, last-variable/root/nonzero/characteristic-zero contract, product-depth +1, exact
rootCost, and complete checked clients with repository-root build commands. The Agent Operator’s Manual needs no edit because roles and procedures are unchanged. No result-registry entry is added for this intermediate formula layer; the sparse-formula size bound is consumed by the separate milestone3 development. The broader #4734 objective remains open.Validation
On this head:
lake build CslibFrontier CslibFrontierResults CslibFrontierTestssucceeds;check_hygiene.pyandcheck_changed_files.py --base origin/mainpass;audit_queries.py duplicatesonComputability/Circuit/Arithmetic/andFoundations/Data/Polynomial/finds no group containing these modules;references --unusedlists only thesimplemmapolynomial_constInput(used implicitly) andnodeCount_ofSparse_le(above).scripts/check.shas a whole was not run. Nosorry. Tests: each operation onx₀x₁ + x₀, and the rootx₀x₁of the formulay − x₀x₁, which gets a formula of product-depth≤ 2.Hosted final-source validation: all six gates, stock/tidy/registry checks, actual notices, Guide examples and both-manual provenance/render review are clear. Canonical independent review/integration evidence. This does not claim a new local whole-library run. Integration waits for #4739 to land and for normal-main reconciliation/current coverage.
AI assistance
Written with Claude Code in a session directed by the author; subagents wrote the formula operations and the root construction from a fixed design. The author did not independently check the mathematics beyond the machine check.
🤖 Generated with Claude Code