Repository navigation
PopoverFocusProbe: the arrowless-panel test doesn't depend on the installed theme - #171
Merged
Merged
Conversation
…om the theme it runs under Under Adwaita, which now draws popover arrows (theme #74), the test got an arrow: it set themeDrawsPanel but left themeDrawsArrow as the installed theme declares it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cxv4UYET1CPcQ6aYfRfRYn
danjboyd
added a commit
that referenced
this pull request
Oct 20, 2026
Pins the theme to the 0.1.0-alpha11 tag (d0416a3). On top of alpha10's overwrite prompt and compact titles: - the toolbar in the menu bar's row is 40pt: 36pt buttons, 20pt icons, 32pt view items and 8pt gaps (#170); - a narrow window's toolbar sends its lowest-priority items into » first, and says so with -toolbarHonoursVisibilityPriority (#171). With it the window's minimum keeps the tools, colour and Copy (#303). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testAThemeThatDrawsThePanelGetsItWithoutAnArrow(#164) failed underTEST_THEME=Adwaitaonce the Adwaita theme began declaringGSThemeDrawsPopoverArrows(plugins-themes-Adwaita #74). The test setsthemeDrawsPanel = YESbut leftthemeDrawsArrowas the running theme declares it (#165), so it got a 132 pt window instead of 120. It now setsthemeDrawsArrow = NO, like a WinUI-style theme. CI runs without the Adwaita theme, so it didn't show there.Found while testing #170 on Linux. Full suite on Linux: all passing under GNUstep's default theme (1 skipped) and under Adwaita.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cxv4UYET1CPcQ6aYfRfRYn