Repository navigation
Toolbar icons: larger glyphs (about 14 px in a 16 px icon) - #301
Conversation
The toolbar SVGs draw their art inside 3 to 21 of a 24-unit grid, and render_toolbar_icons.py rendered the whole grid. So a glyph filled about 62% of its icon: in WinUITheme's 16 px toolbar icon it came out 10 px, where Snipping Tool and Photos draw 14 to 16 px. The script now renders the middle 18 units at every size, so the same art comes out about 14 px at 16 px. The art itself is unchanged. The 16 px hints for NumberedStep and Rectangle are gone: they were hinted to the old 16 px scale and lose their edges at the new one. All PNGs re-rendered with the script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Px6i2CANZszJmJLzAZHoBQ
|
Linux check (391be47 against main beaa38b): looks good. Private GNOME Shell (X11), at 1× and 2× (
🤖 Generated with Claude Code |
|
Windows: GO. I tested preview MSI 0.3.1-pr301 (run 39469845166, 391be47) on Windows 11 with WinUITheme alpha10, against rc2. Measured from PrintWindow captures:
The toolbar layout, targets and row height are unchanged, with nothing clipped and nothing in ». Dark mode at 150% also looks right. Before/after strips at 100% and 150% (1:1) are in section 5 of the toolbar report: https://claude.ai/artifact/5g34jF2VfEnMyeoz7T8XuS (private to Dan's account). Item 2 (wider gaps) is now in WinUITheme's toolbar-40 work for alpha11: 4 pt per side, 8 between items. It isn't needed in this PR. 🤖 Generated with Claude Code |
|
macOS check (391be47 against main beaa38b): looks good. macOS 26, arm64 build (
macOS GO for #301. The merge is Dan's call. 🤖 Generated with Claude Code |
|
Correction to my note above: "below about 800 pt the tool group runs past the window's right edge" came from resizing through accessibility, which bypasses the window's minimum width. Dragged by hand, main's window stops at 772 pt with the tools showing (details on #303). This doesn't change the GO for #301. 🤖 Generated with Claude Code |
For 0.3.2. Dan's decision on the toolbar-size report (https://claude.ai/artifact/5g34jF2VfEnMyeoz7T8XuS), item 1.
What changes. The toolbar's glyphs fill about 85% of their icon instead of about 62%. In WinUITheme's 16 px toolbar icon they come out at about 14 px instead of 10. Snipping Tool and Photos use 14–16 px.
How. Assets only, no new art. The SVGs draw inside 3–21 of their 24-unit grid.
scripts/render_toolbar_icons.pynow renders that middle 18 units at every size, and all the-NN-symbolic.pngfiles are re-rendered with it. The 16 px hinted drawings for NumberedStep and Rectangle are removed, because they were hinted to the old scale.Every platform gets this: GNUstep (WinUITheme, Adwaita and the default theme) and macOS use these PNGs.
Not in this PR: the wider gaps between groups (item 2). They come from the theme (
WinUIThemeToolbarSpacing), and WinUITheme alpha11's 40 px toolbar sets them to 4 pt per side.Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01Px6i2CANZszJmJLzAZHoBQ