Repository navigation
Toolbar: least-used items overflow first; the tools, colour and Copy never do - #303
Conversation
…never do Every platform now ranks the toolbar's items for the overflow menu, by visibility priority: - Undo and Redo go first (Low), and Zoom and Preferences when customised in, as they're in the menus with shortcuts; - then custom actions (Standard); - then Save and Share (High). On macOS Share used to go first, into #298's empty picker; - the tools, colour and Copy never go (User). AppKit honours the priorities. On GNUstep they take effect once the theme does; libs-gui keeps the row's first items. So on GNUstep the window's minimum width now reaches past Copy, plus the ">>" button. Under Adwaita's header bar it counts the room the title keeps. macOS's minimum keeps Copy as well as the tools and colour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
…priority libs-gui moves the row's last items into ">>", so keeping Copy there kept everything before it: about 1174px under Adwaita, too wide for a window on half a 1920px screen. GNUstep keeps the 640pt canvas minimum again, and Copy may overflow. A theme that sends the lowest priority into ">>" first says so with -toolbarHonoursVisibilityPriority. WinUITheme and Adwaita are adding it, on the theme object so that it goes away with the theme. Under such a theme the minimum keeps the tools, colour and Copy, the flexible spaces (Adwaita's title room) and the ">>" button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
… half a screen With WinUITheme's priority overflow, the window can't be narrowed past the tools, colour and Copy. That was about 672pt, more than half of a 1920px screen at 150% (640pt). WinUI's segmented icon items are 40pt: the tools take 54pt less there, and each is still a 40px touch target. Linux and macOS keep 46. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
|
macOS check (0d03e74 against main beaa38b): looks good. macOS 26, arm64 build, 1× display, light appearance. I dragged the window's corner by hand to its narrowest, then widened it in 8 pt steps and read the visible toolbar items through accessibility.
A correction to my #301 note: "below about 800 pt the tool group runs past the window edge" only happened because I resized through accessibility, which bypasses the window's minimum width. Dragged by hand, main stops at 772 pt with the tools showing. So on macOS #303's real gains are Copy staying visible and Share outlasting Undo and Redo. macOS GO for #303. The merge is Dan's call. 🤖 Generated with Claude Code |
… and 150% Under WinUITheme's priority overflow at 125% and 150%, Copy went into ">>" at exactly the window's minimum, 2px short of fitting. The theme rounds the items to whole pixels, so their sum in points came out short. Measured on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
|
Windows: GO on c4ef8f4 (preview 0.3.1-pr303b), run on Windows 11 with the installed app. The VM display is 2293×1302. Widths are visible (DWM) px. Before (0d03e74):
After (c4ef8f4):
🤖 Generated with Claude Code |
Pins the theme to the 0.1.0-alpha11 tag (d0416a3). On top of alpha10's overwrite prompt and compact titles: - the toolbar in the menu bar's row is 40pt: 36pt buttons, 20pt icons, 32pt view items and 8pt gaps (#170); - a narrow window's toolbar sends its lowest-priority items into » first, and says so with -toolbarHonoursVisibilityPriority (#171). With it the window's minimum keeps the tools, colour and Copy (#303). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
…een at 150% At 150% the 640pt canvas minimum was exactly 960px, half of a 1920px screen, with nothing to spare. At 600pt it's 900px. Under WinUITheme alpha11 the window's minimum still keeps the tools, colour and Copy (kept items plus 4pt), measured below the canvas minimum on Windows. Linux keeps 640pt, and macOS its measured minimum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
|
Windows: GO on 7fe8121 (preview 0.3.1-pr303c), with a 600 pt canvas minimum on Windows. Tested on Windows 11 with the installed app, on a 2293×1302 display. Widths are visible px.
🤖 Generated with Claude Code |
For 0.3.2, the app part of Dan's toolbar-overflow plan, with option (b) for GNUstep.
Ranking (every platform,
NSToolbarItem visibilityPriority)Minimum window width
-toolbarHonoursVisibilityPriority, a method on the GSTheme subclass, so it goes away with the theme on a live switch. WinUITheme and Adwaita are adding it on theirtoolbar-overflow-prioritybranches.Tests (ToolbarFitsWindowProbe)
testItemsOverflowInOrderOfUseruns on every platform.testWithoutPriorityTheMinimumIsTheCanvasMinimumfails on 824eac0 (854 pt in CI's layout).testWithPriorityTheMinimumKeepsTheToolsColourAndCopygives the theme the method at runtime.testTheNarrowestWindowStillShowsTheToolsColourAndCopy.For the 0.3.2 release notes: "When the window is too narrow for the whole toolbar, Undo and Redo go into the » menu first and Save and Share last. On macOS the tools, colour and Copy always stay. On Linux and Windows this ordering, and keeping Copy on screen, need the bundled theme to support it: WinUITheme and Adwaita do. With older themes, items go into » from the end of the row as before."
🤖 Generated with Claude Code
https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW