Repository navigation
Packaging: gnustep-packager v0.1.2, and the vendored updater synced from v0.1.1 - #302
Merged
Merged
Conversation
The release and Windows preview workflows call the packager's shared workflow at the v0.1.1 tag instead of main. They no longer pass packager-repository and packager-ref: with them unset, the workflow checks out its own commit (gnustep-packager #57). Keeping packager-ref: main would have run main's scripts under the v0.1.1 workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
Picks up, since 44b18e0: - the update window's progress label is unbezeled (#58); - a failed install is reported at the next launch, with msiexec's exit code in plain words (#37); - View Changes and Skip This Version can be reached on GNUstep (#50); - URLs open through ShellExecuteW on Windows. The app already links shell32 there; - two unused symbols are removed, which silences two build warnings. The local -DHAVE_MODE_T in the three Makefiles is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
v0.1.2 adds gnustep-packager #63: a relative path on the command line (./ScreenshotTool.AppImage Pictures/x.png, or ScreenshotTool.exe docs\x.png through the MSI launcher) resolves against the caller's directory instead of the bundle's. Its updater is the same as v0.1.1's, which the vendored copy is synced from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
danjboyd
changed the title
Owner
Author
|
Moved to gnustep-packager v0.1.2 (aa1c9ac) in a684f8b. It adds #63: relative command-line paths resolve against the caller's directory. v0.1.2's updater is the same as v0.1.1's, so the vendored sync (d67204f) stands. The preview MSIs already building from d67204f still test the updater. A relative-path launch check ( 🤖 Generated with Claude Code |
GitHub moves ubuntu-latest to Ubuntu 26 from October 2026. The AppImage is built and its libraries bundled on the packaging runner, so its base and glibc floor would have changed silently. The packager's AppImage job (runs-on-appimage), the release's other Linux jobs and the feed redeploy now name ubuntu-24.04, which build.yml already uses and v0.3.1 was built on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
Owner
Author
|
Windows: GO. I tested CI preview MSIs on Windows 11, using the installed app through its launcher. The update tests used a
rc90 and rc91 were built from d67204f, before the v0.1.2 pin. As agreed, the updater code they test is the same at a684f8b. 🤖 Generated with Claude Code |
Both change package-linux in release.yml. #302 drops packager-repository and packager-ref, and #304 adds runs-on-appimage, which v0.1.2's shared workflow takes. Resolved here so that #302 merges cleanly after #304. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
danjboyd
marked this pull request as ready for review
October 20, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 0.3.2. Two commits:
Workflows (8dab9ee):
release.yml(both packaging jobs) andpackage-windows-preview.ymlcall the packager's shared workflow at@v0.1.1instead of@main. They droppackager-repositoryandpackager-ref: main: with those unset, the workflow checks out its own commit (gnustep-packager Replace custom-drawn toolbar views and STThemeUtilities colours with standard controls and system colours #57). Keepingpackager-ref: mainwould have run main's scripts under the v0.1.1 workflow.Vendored updater (d67204f):
third_party/gnustep-packager-updatersynced from v0.1.1 (23f1708); it was at 44b18e0. It picks up:The local
-DHAVE_MODE_Tstays in the three Makefiles.Linux: it builds, with two fewer warnings. The tests pass, 63 suites under both themes (3 skipped under default, 2 under Adwaita).
Still to do: a release-workflow run on the branch (Linux AppImage and Windows MSI), and an update test from 0.3.1 on Windows and Linux. If packager v0.1.2 (#63, relative paths) is tagged first, this moves to v0.1.2.
🤖 Generated with Claude Code
https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW