Repository navigation
Chapter 2 goal: sell 3 item kinds so chapter 3 opens earlier - #20
Merged
Merged
Conversation
…(constants moved to config.ts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT, game-value change, measure before merge.
Diagnosis (from code, no sims run): the chapter 2 goal of 5 item kinds gates chapter 3 (woolshed opens at season 7; the sim farmer repeats a few kinds), and the rare screen and fair open with chapter 3.
Change: ITEM_TYPES_FOR_CH2 5 to 3 (and ORDERS_FOR_CH2) moved into config.ts; the chapter 2 test and the DESIGN-v3 §10.1 table updated.
Tests: npm test (381) and typecheck pass.
Measure: run packages/game/scripts/blind.ts in chunks of at most 8 seeds (1-8, 9-16, 17-24, 25-30); compare actSeason[3] median and rare-by-27 against 15 and 2/30. I could not confirm the exact invocation from the docs.
Queued from the dashboard (item 544). The request:
Opened by the queue runner on LXC 113. Merged once CI checks pass and the reviewer's verdict is recorded, unless it touches a hard line (qrunner/hardlines.toml): then it waits for Joshua's yes on the dashboard.
🤖 Generated with Claude Code