Add MTG and MTG_pvlib configs - #24
Merged
Merged
Conversation
ElloiseFangelLloyd
approved these changes
Sep 8, 2026
ElloiseFangelLloyd
left a comment
There was a problem hiding this comment.
Both cases work well for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding configurations to allow running with MTG data produced by
specMAGIC(https://github.com/dmidk/specMAGIC).Specifically, two configurations are added:
MTGandMTG_pvlib. The former uses clear sky calculated byspecMAGICdirectly, while the latter uses climatological clearsky calculated via thepvlibpackage. The latter is much slower, but does not requirespecMAGICclearsky.MTG_pvlibrequires GHI values for the requested time as well as the three preceding time steps.MTGadditionally requiresCSR(clear sky) values for the four same time steps as well as 24 time steps from the previous day starting at the requested valid time and going forward in time.To make running with different datasets easier, the option of providing more configuration parameters to
config.yamlhas been added. This overwrites the hard-coded defaults for the parameters previously given as environment variables. Environment variables still take priority. For now, the value of 10 forinput_data_frequency_minuteshas been added for the MTG configurations directly.To run with MTG data, one simply needs to export the
SATELLITE_DATA_DIRECTORYto point to the out directory containing thespecMAGICoutput directories:export SATELLITE_DATA_DIRECTORY=<PATH/TO/SPECMATIC>/outsunflow --run_mode files --dataset MTG_pvlib --time <datetime in ISO8601 format>sunflow --run_mode files --dataset MTG --time <datetime in ISO8601 format>