Repository navigation
🔥 Generating a frozen embedding store makes one plain request - #74
Open
ebigunso wants to merge 3 commits into
Conversation
…-metrics-keys' into feature/2026-09-29/evals-cleanup-plain-embedding-request
…-metrics-keys' into feature/2026-09-29/evals-cleanup-plain-embedding-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating a frozen embedding store makes one plain request (evals value-audit cleanup Task_3).
--api-key-envand--dimensionsflags are gone: no config or committed store ever used them. The key is read fromOPENAI_API_KEY.Three files, a net 145 lines fewer. All eight frozen fixture, manifest and store hashes are unchanged, and no test calls the provider. Tests: 411 top-level plus 2 child runs, none excluded. evals-reviewer APPROVED with no findings.
Stacked on #73.
🤖 Generated with Claude Code