Skip to content

🔥 Generating a frozen embedding store makes one plain request - #74

Open
ebigunso wants to merge 3 commits into
feature/2026-09-29/evals-cleanup-metrics-keysfrom
feature/2026-09-29/evals-cleanup-plain-embedding-request
Open

ebigunso wants to merge 3 commits into
feature/2026-09-29/evals-cleanup-metrics-keysfrom
feature/2026-09-29/evals-cleanup-plain-embedding-request

Conversation

@ebigunso

Copy link
Copy Markdown
Owner

Generating a frozen embedding store makes one plain request (evals value-audit cleanup Task_3).

  • The retry policy, loop and backoff are gone. The only caller passed "no retry", and the README already said retries are avoided so that a billable call is never duplicated.
  • The OpenAI response error enum becomes plain error context with the same messages. Every response check and its order are kept, including optional dimension validation.
  • The --api-key-env and --dimensions flags are gone: no config or committed store ever used them. The key is read from OPENAI_API_KEY.

Three files, a net 145 lines fewer. All eight frozen fixture, manifest and store hashes are unchanged, and no test calls the provider. Tests: 411 top-level plus 2 child runs, none excluded. evals-reviewer APPROVED with no findings.

Stacked on #73.

🤖 Generated with Claude Code

…-metrics-keys' into feature/2026-09-29/evals-cleanup-plain-embedding-request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant