Repository navigation
fix(ec2,sagemaker): real capacity-reservation split/capacity blocks and model-driven SageMaker describe shapes - #2733
Merged
Conversation
…SageMaker describe shapes - EC2: CreateCapacityReservationBySplitting / MoveCapacityToCapacityReservation move real capacity, answer DryRun first, record createDate on split. - EC2: DescribeCapacityBlockOfferings returns real offerings per the user-guide duration/booking-window rules; PurchaseCapacityBlock consumes one and creates a scheduled capacity-block reservation. - SageMaker: Describe* outputs are projected from the stored request through the model (derive.rs/shape.rs), including DescribeCluster instance-group status fields, ForUpdate partial-update merges, ProfilingStatus and OnDemand throughput. - Conformance: DryRunOperation accepted as EC2's documented common error.
…er-describe # Conflicts: # crates/fakecloud-e2e/tests/sagemaker.rs # crates/fakecloud-ec2/src/service/capacity.rs
…rging main Main's engine now wraps DescribeWorkforce/Workteam output itself (WRAPPED_OUTPUTS), so derive only transforms the record; wrapping there too projected an empty inner view. Shape test sends a complete VPC config, which main's validation now requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EC2
CreateCapacityReservationBySplitting/MoveCapacityToCapacityReservationnow move real capacity between reservations instead of echoing synthesized ones. The split destination is a fresh active On-Demand reservation (source config, no tags/history/interruptible allocation) withcreateDate == startDate ==split time. Client tokens replay idempotently.DryRunOperation(EC2's documented common error, 412) is added to the probe's EC2 accepted-error list.DescribeCapacityBlockOfferingsreturns real offerings per the user-guide rules (1-14 days in 1-day steps or up to 182 in 7-day steps, 1-64 instances, 11:30 UTC starts within 8 weeks).PurchaseCapacityBlockconsumes an offering and creates ascheduledcapacity-block reservation. No invented prices.SageMaker
derive.rs,shape.rs): DescribeCluster instance groups asClusterInstanceGroupDetails(current/desired pairs,InService), inference componentDeployedImage+ copy counts, human task UIContentSha256,ProfilingStatusfromDisableProfiler, OnDemand feature groups without provisioned units, work teamWorkforceArn.*ForUpdatemembers, generated from the model) merge into stored state instead of replacing it.intEnumleaves get modelled values;dispatchparses and serializes once.Test plan
cargo clippy --workspace --all-targets -D warnings,cargo fmt --checkcargo test -p fakecloud-conformance --test ec2 --test sagemakersagemaker(14),ec2_capacity_reservation_splitrun --services sagemaker,ec2: 43106/43106, 1211/1211 opsNo SDK/docs surface change (no new introspection endpoints, op counts unchanged).
Summary by cubic
Makes EC2 capacity-reservation splitting and capacity blocks move real capacity instead of echoing synthesized data, and projects SageMaker read responses through the Smithy model's output shapes instead of echoing the stored request.
EC2
CreateCapacityReservationBySplittingandMoveCapacityToCapacityReservationtransfer capacity between actual reservations; the split destination is a fresh active On-Demand reservation with no tags or history, and client tokens replay idempotently.DryRunOperationis accepted as EC2's documented common error.DescribeCapacityBlockOfferingsreturns real offerings following the user-guide duration, step, and booking-window rules, andPurchaseCapacityBlockconsumes one to create a scheduled capacity-block reservation with no invented prices.SageMaker
InService, inference components report deployed images and copy counts, human task UIs reportContentSha256, andProfilingStatusand On-Demand throughput come from stored state.*ForUpdatemembers) merge into stored state instead of replacing it, and required output members are synthesized from each element's own identifiers.No new endpoints or SDK surface changes; operation counts are unchanged.
Written for commit 429fc83. Summary will update on new commits.