Repository navigation
Fix period_beginning_converted_balance in int_quickbooks__retained_earnings - #231
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #230
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
Changes
period_beginning_converted_balanceinint_quickbooks__retained_earningsto lagperiod_ending_converted_balanceinstead ofperiod_ending_balance. The beginning converted balance of the Net Income Adjustment row now matches the prior period's ending converted balance.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB with the integration test data. For
account_id = '9999'inquickbooks__general_ledger_by_period, periods whereperiod_beginning_converted_balancediffers from the prior period'speriod_ending_converted_balancego from 73 of 86 to 0. For 2026-02-01,period_beginning_converted_balancegoes from 61460 to 50423, matchingperiod_ending_converted_balancewith a net converted change of 0. Unconverted columns and row counts (3698) are unchanged.dbt buildpasses.