Repository navigation
fix(toolbar): keep zoom controls stable at scale boundaries - #410
Merged
Merged
Conversation
Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 20.14.5 to 21.0.1. - [Release notes](https://github.com/capricorn86/happy-dom/releases) - [Commits](capricorn86/happy-dom@v20.14.5...v21.0.1) --- updated-dependencies: - dependency-name: happy-dom dependency-version: 21.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/happy-dom-21.0.1
Source commit: 31bd8e861cc53af3d9c3e99f846cb4483301c275
Source commit: c032fd6b578850896ec63f14c5f005c6590798b5
Source commit: f44b5511916b919e512206eac198b0d43ece3989
Source commit: c3590741e7b173a7dee25560b58c65cc9cd73e75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolbar.items['zoom-reset']visibility option while retaining API reset behavior and explicit zoom permissions. Share visibility policy through an additive core helper without changing the public toolbar-state interface.pdf.zoomToolbar: falseto hide only the PDF renderer's zoom group while retaining page navigation and rotation. Existingpdf.toolbar: falsebehavior remains supported.test:toolbar-zoom-github-398into the main CI command. Run the real interaction regression in Chromium and WebKit and upload its evidence.c3590741e7b173a7dee25560b58c65cc9cd73e75.Related issue
Closes #398. Package release is pending; this PR changes source on main.
Change classification
Verification
pnpm test:toolbar-zoom-github-398vitest runandpnpm type-checkpnpm verify:vue3-toolbar-browser183e93c474b98706596c8119b8e71a5ad81c8804: complete Public CI, focused, cold consumers, security and governance passed; independent runtime and CI-delta reviews found no blockers. Chromium/WebKit are desktop engines, not an iOS device claimSample / fixture evidence
verify-vue3-toolbar-browser.mjs: image and 13-page PDF.apps/component-demo/scripts/verify-zoom-toolbar-browser.mjsperforms actual source cancellation, delayed old-response completion, repeated pointer clicks, navigation and rotation.Visual evidence
Captured from the validated implementation at 1280×800. Final-head Chromium/WebKit reports and screenshots record seven passing cases per engine, zero external requests and zero page errors; current artifact screenshots were visually checked.
Risk and compatibility
Checklist