Repository navigation
ci(bindings): fix the macOS universal2 lipo paths - #7
Merged
Merged
Conversation
napi build --platform routes the host slice through target/<triple>/release like any explicit --target build, so the universal2 lipo step looked for target/release/libllm_proxy_node.dylib and found nothing. Both slices now come from explicit triples read at deterministic paths, independent of runner architecture.
An explicit --target napi build skips generating binding.js/binding.d.ts, so the runner's index.js found no loader to require. npm run build (plain --platform) generates them, and run 1's failure proves --platform puts the host dylib under target/aarch64-apple-darwin/release/ rather than target/release/, which is where lipo now reads it.
hmziqrs
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6 merged before this fix landed on the branch, so master's first
bindings-macosrun failed (lipo: can't open input file: target/release/libllm_proxy_node.dylib) and the one commit master is missing is this one.napi build --platformroutes the host arm64 slice throughtarget/<triple>/releaselike any explicit--targetbuild, so the universal2 lipo step looked for the host slice attarget/release/and found nothing. Both slices now build with explicit triples and lipo reads two deterministic paths, independent of runner architecture.Note: on PR #6's run, the Python half of the job passed on real macOS (universal2 wheel installed into a venv, pytest green) — only the Node lipo path was wrong. This is the first CI-tested push of the fix (pushing to a merged branch fires no workflow).