Skip to content

ci(bindings): fix the macOS universal2 lipo paths #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmziqrs merged 2 commits into from
Nov 9, 2026
Merged

ci(bindings): fix the macOS universal2 lipo paths #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf0062e
ci(bindings): read both lipo slices from their target-triple dirs
hmziqagent Nov 9, 2026
0e770a3
ci(bindings): build the Node loader with the package's own build script
hmziqagent Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,14 @@ jobs:
working-directory: bindings/node
run: |
npm ci
# Generates binding.js/binding.d.ts and the host arm64 slice.
npx napi build --platform --release --js binding.js --dts binding.d.ts
# The package's own build script generates binding.js/binding.d.ts
# and the host arm64 slice; napi build --platform passes the host
# triple to cargo, so that dylib lands under target/<triple>/release
# (an explicit --target build skips generating the loader files).
npm run build
cargo build --release --target x86_64-apple-darwin
lipo -create -output llm-proxy.darwin-universal.node \
target/release/libllm_proxy_node.dylib \
target/aarch64-apple-darwin/release/libllm_proxy_node.dylib \
target/x86_64-apple-darwin/release/libllm_proxy_node.dylib
node --test test/

Expand Down
Loading