Repository navigation
chore: Move to maintained YAML module and tighten go.mod floor - #1407
Merged
Merged
Conversation
- Import go.yaml.in/yaml/v3 instead of the archived gopkg.in/yaml.v3. It is the same API, maintained by the YAML organisation, and was already in the module graph through cobra. gopkg.in/yaml.v3 is no longer linked into any package built from this module. - Raise the go directive to 1.27.2 so the patched standard library is a hard minimum rather than a toolchain hint that GOTOOLCHAIN=local ignores. The separate toolchain line is now redundant and dropped. - Bump every tagged indirect requirement to its latest release (ProtonMail/go-crypto 1.5.2, circl 1.6.5, x/crypto 0.58.0, x/net 0.61.0, x/sys 0.49.0, mergo 1.0.2, ...) and replace the go-diff pseudo-version with tagged v1.4.0. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Isaac Schepp <isaac.schepp@gmail.com>
Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Isaac Schepp <isaac.schepp@gmail.com>
Deploying genealogix with
|
| Latest commit: |
462a931
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9f556417.genealogix.pages.dev |
| Branch Preview URL: | https://chore-go-mod-hygiene.genealogix.pages.dev |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
noahbjohnson
approved these changes
Oct 18, 2026
isaacschepp
added a commit
that referenced
this pull request
Oct 27, 2026
Address the three regressions from review of #1397: - Refuse a planned write whose parent resolves under a dot-prefixed directory (e.g. persons -> .drafts/persons). The loader skips those, so merge and migrate reported entities that the next load could not see. The check lives in parentStaysInside, so rename's preflight gets it too. - Write out a standard vocabulary the result references when no archive file defines it. The validating load checks references before it fills the standard vocabularies, so merging a birth/subject event into an archive with no vocabulary files produced an archive glx validate rejected. The writer now runs that same validating load over the post-write file set and materializes only the vocabularies it names. - Pick the metadata owner the way GLXFile.Merge does: the first block with content. An earlier `metadata: {}` no longer receives the block, which left two populated metadata blocks and a validation conflict. Also switch archive_inplace.go to go.yaml.in/yaml/v3. The merge of main (#1407) left it importing gopkg.in/yaml.v3, which the module no longer requires, so the head did not build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
isaacschepp
added a commit
that referenced
this pull request
Oct 27, 2026
Resolve the CHANGELOG.md and Makefile conflicts: - CHANGELOG.md: keep the changie-rendered file. The 12 [Unreleased] entries main gained since the last merge (#1382, #1384, #1386, #1393, #1395, #1396, #1407, #1413) become fragments Added-main-56 .. Fixed-main-67, with trailing/inline refs moved into custom.Issue as in the existing migrated fragments. Main's released sections were unchanged since the merge base. - Makefile: .PHONY carries both main's lint-workflows and this branch's changelog/changelog-check targets. - tools/fragmentcheck: import go.yaml.in/yaml/v3. #1407 dropped gopkg.in/yaml.v3 from go.mod, so the checker no longer built and `make changelog-check` failed with "go mod tidy needed". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Dependency hygiene from a review of
go.mod:gopkg.in/yaml.v3now usego.yaml.in/yaml/v3, its maintained drop-in successor (same API, maintained by the YAML organisation). It was already in the module graph through cobra, so the project now links one YAML parser instead of two.NOTICEis updated to match.gopkg.in/yaml.v3is no longer linked into any package built from this module (go list -deps ./...).go 1.27.0+toolchain go1.27.2becomesgo 1.27.2. The toolchain line is only a hint: a build withGOTOOLCHAIN=localon Go 1.27.0/1.27.1 (for example, a distro packager) ignored it and shipped the standard-library vulnerabilities fix: Bump Go toolchain to 1.27.2 for standard library vulnerabilities #1381 meant to exclude. Thetoolchainline is now redundant and dropped. CI readsgo-version-file: go.mod, so it is unaffected.ProtonMail/go-crypto1.1.6 → 1.5.2,circl1.6.3 → 1.6.5,x/crypto0.58.0,x/net0.61.0,x/sys0.49.0,mergo1.0.2,ssh_config1.6.0.sergi/go-diffmoves from a 2023 pseudo-version to tagged v1.4.0.x/text(direct) goes to 0.43.0, pulled in byx/net.Related issues
None. Follow-up from a
go.modreview.Review focus
The YAML swap.
go.yaml.in/yaml/v3v3.0.5 is a later release of the same codebase thangopkg.in/yaml.v3v3.0.1. The full test suite, including the example-archive round-trip and serializer tests, passes unchanged.Testing
go test -timeout 10m ./...: all passgo mod tidy -diffclean,go mod verify: all modules verifiedgolangci-lint run --new-from-rev=origin/main ./...: 0 issues. The full-run count is no higher than onmain, so thegobump surfaces no new findings.Breaking changes
Downstream modules importing
github.com/genealogix/glx/go-glxnow needgo >= 1.27.2(previously 1.27.0).