fix(export): size a GIF from the source, not the hidden MP4 tier - #861
Merged
EtienneLescot merged 1 commit intoSep 27, 2026
Merged
EtienneLescot merged 1 commit into
EtienneLescot merged 1 commit into
Conversation
A GIF started from whatever MP4 quality tier was last picked, a control the GIF settings do not show: a 640x360 clip gave an 852x480 README GIF straight away and a 640x360 one after Studio. It now starts from the "Source" size in both the export and the destination summary, so no preset upscales and Original means the source size. MP4 is unchanged.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A GIF's size no longer depends on the MP4 quality tier, a control the GIF settings hide. It starts from the "Source" size (the smallest clip's true footprint, so nothing is upscaled), then the size preset caps its height.
gifOutputDims.Originalnow means the source size.Reported on #814 with a 640×360 source: README GIF gave 852×480 when picked directly, 640×360 after Studio. It is now 640×360 both ways.
Related issue
Refs #814
Type of change
Release impact
Desktop impact
Testing
ExportDialog.params.test.tsx: the tester's path (summary and export params, direct vs. after Studio), and every MP4 tier × GIF size preset on a 640×360 source. Both failed before the fix with 852×480.npx vitest --run src/components/ai-edition/: 69/69 files, 549 tests pass.npx tsc --noEmitandnpx tsc -p tsconfig.test.json --noEmit: clean.npm run lint: the only errors are format errors on files checked out as CRLF (core.autocrlf), none in this diff.biome checkon the two changed files passes.Left as is
The CLI (
src/cli/CliExportRunner.tsx) still sizes a GIF from--quality. That is documented inwebsite/docs/cli.md("A GIF starts from this size too"), so aligning it would change a documented flag and its translations.🤖 Generated with Claude Code