Repository navigation
test(ci): cover checksum helper paths containing spaces - #25
Merged
Merged
Conversation
Signed-off-by: jabrailkhalil <jabrailkhalil@gmail.com>
Maxerns
approved these changes
Sep 10, 2026
Maxerns
left a comment
Contributor
There was a problem hiding this comment.
Thanks @jabrailkhalil this is thorough work. I executed the POSIX spaced-path cases end to end here in both PATH modes (full and shasum-fallback) and they pass exactly as written. Approving ci now and ill merge when its green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds regression coverage for the checksum helpers when the asset or manifest lives under a parent directory containing spaces, and when the helper is invoked by absolute path from an unrelated working directory. Scope is spaces in parent directories only; helper behaviour is unchanged.
Closes #23
Changes
Extends the
reject-tampered-checksumjob in.github/workflows/test.yml:"$RUNNER_TEMP/dir with spaces"and invokesscripts/verify-checksum.shby absolute path from$RUNNER_TEMP. The valid invocation succeeds, then a tampered copy fails with the existingerror: checksum verification failed for sotto-fixture.shasumfallback with spaced paths.scripts/verify-checksum.ps1, deriving the manifest hash from the copied fixture so line-ending differences in the working copy cannot invalidate it.No new dependencies, no extra runners, no release downloads. Tracked fixtures are untouched.
Verification
Replicated both blocks locally:
sha256sumpath): valid and tampered spaced checks pass.shasum+awk(macOS leg fallback): valid and tampered spaced checks pass.Commits are signed off (
git commit -s) per the issue instructions.