Bind V5 review evidence and identities end to end

[joshlf]

Dry-running the executable V5 lifecycle exposed a remaining trust gap: static
integration still began with a caller-supplied reviewed semantic overlay, while
production had no public evidence-bearing path for authoring the review receipts
that supposedly authorized it. The fixture contract also bound a source digest
and prompt summary rather than the complete prompt, input-plan, and launch
material actually consumed by each mode.

Adversarial review found related failures at those boundaries. Exact-quotation
matching erased meaningful whitespace and did not confine excerpts to their
cited rustdoc fragments. Several anchors and excerpts were stale, and the V4
lineage record overstated a frozen page-byte manifest as review of current V5
propositions. READY evaluator inputs could retain DRAFT schema prose. Review
receipts admitted opaque PASS claims, synthetic receipts could be made
production-shaped by renaming actors, and reviewer identities could be reused
across phases or at runtime.

The executable lifecycle also had concrete integrity and availability bugs:
report targets and condition packages could be coherently rebound; production
leases initially called an undefined helper; persisted peer leases were not
universally checked; receipt metadata, validation, copying, and identity
extraction reopened mutable paths; finalization could bless a coherently swapped
bundle after publication; and the hardened receipt predicate made genuine
production finalization reject its own prematurely-writable stage.

Add an explicit reviewed-source boundary before snapshot construction.
prepare-source-review now derives an immutable candidate from the 38 DRAFT
semantic templates, trusted declaration, eight exact target trees, requested
values and seeds, and complete trusted reviewer-tool inventory. Two independent
oracle reviews and one coherence review operate on disjoint verified private
copies. Their contracts bind the concrete procedure and receipt schema,
reviewer runtime, exact artifact and coverage sets, theorem inputs, and itemized
reviewer-authored work products. Trusted builders validate and no-replace
publish canonical read-only receipts, and finalize-reviewed-inputs preserves
those exact bytes.

Carry the same discipline through snapshot review and execution. Snapshot
contracts bind their procedure, schema, tool/runtime identity, acceptance
requirements, complete coverage, and work product. Require three distinct
source reviewers and eight distinct snapshot reviewers, disjoint across both
sets. Permanently exclude all eleven identities from runtime roles, and enforce
the canonical actor grammar against every persisted lease during acquisition,
sealing, state verification, and aggregate reconstruction.

Capture every production receipt once through an
O_NOFOLLOW/O_CLOEXEC/O_NONBLOCK descriptor, verify canonical 0444 regular-file
bytes and stable inode metadata, and use only that capture for validation,
copying, hashes, and reviewer identity. Parse the lock-authenticated framed
manifest strictly and bind source receipt captures to their exact path, kind,
size, mode, and SHA-256 records. Return the lock and reviewer exclusion set from
one coherent verification operation so protocol callers never reopen receipts.

Derive and recheck the external commitment from the verified private
finalization stage before no-replace publication. Verify the published path,
require it to reproduce that exact identity, and only then publish the
separately custodied commitment. Verify a copied review candidate while its
receipts remain read-only before opening the private stage for finalization.

Make fixture identity exact across lifecycle phases. Replace ambiguous source
and prompt fields with BYTE_TREE_V1 source bindings and a
V5_MODE_REPORT_MATERIAL_SET_V1 digest over all fifteen prompt, input-plan, and
launch records per mode. Leave the report-material binding explicitly
unresolved during source review, derive it after snapshot construction, and
byte-check the DRAFT-to-candidate-to-READY transitions. Deterministically
promote schema lifecycle comments and reject stale DRAFT or UNSEALED prose in
evaluator-mounted schemas.

Correct the authority oracle at the same boundary. Scope quotation checks to
real rustdoc fragments and single semantic elements while preserving word
boundaries and punctuation. Repair function, block, match, call, array,
method-call, textual, enum-variant, invalid-value, and associated-constant
anchors; correct the get_unchecked, unwrap_unchecked, and NonZero excerpts; and
add missing cfg-option, cfg-removal, and equality premises. Narrow reused V4
provenance to page bytes bound by its frozen manifest rather than claiming that
V4 reviewed current V5 content. Bind 130 locator records and 146 URL edges with
the exact-quotation evidence digest, and regenerate the 142-record neutral
projection and per-mode allowlists.

Expand regression coverage for quotation and lineage drift, forged fixture and
report-material bindings, stale schema markers, incomplete work products,
missing evidence and receipts, special receipt entries, synthetic-to-production
promotion, duplicate or overlapping reviewers, pathname/inode substitution,
late identity rereads, poisoned runtime leases, and coherent post-publication
bundle replacement. Exercise a complete mechanically production-shaped 3+8
review, finalization, external commitment, and verification lifecycle. This
proves the public mechanics are live; it does not claim that human reviewers
honestly performed the generated test reviews.

Validation passes for preparation, integration, and protocol DRAFT checks and
self-tests; the full mechanical production and synthetic lifecycles; all four
semantic validators; 115 atoms and 35 controls with complete coverage; eight
fixture manifests; 69 authority entries; 83 strict JSON files; 52 schema
declarations; all CLI help surfaces; AST and unresolved-global checks; and
cache/diff cleanliness. Independent authority review verified 130 locator
records and 146 URL edges over 58 pinned official pages. A final independent
adversarial replay found no remaining issue at any severity.

This remains diagnostic infrastructure. No genuine independent production
review receipts, semantic reports, scores, or evaluation result are recorded
here. G-ISOLATION and G-OUTPUT-FINALIZATION remain fixed FAIL and release
eligibility remains false. Reviewer authentication and honesty, private-copy
custody, trusted Python and filesystem semantics, external-commitment custody,
and SHA-256 collision resistance remain explicit TCB premises.

Review basis: HEAD eeb84a8d58158678c1c5c6a57713fe38321938f4;
integrate.py 8a6e267b3b92fae1bbc7b87c57e549fa34ad81910340b744d5b4a99b69479ab3;
protocol.py 0daab7a161e11aa0f7d18f0865f7e5ffbfd1a0acd645f73aaa799a33da8ab4c0;
34-file fingerprint 87a1158ad80d1d9458cb9b9e06777806efe97128e7ddfb1c8caf7151a64bb351.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-29T10:48:39.601645Z	b1e88b3	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (Ghchu3g3fkri2ofhgm5addjto4rfkyvyi@245af42). Learn more about missing BASE report.

Additional details and impacted files

@@                         Coverage Diff                          @@
##             Ghchu3g3fkri2ofhgm5addjto4rfkyvyi    #3604   +/-   ##
====================================================================
  Coverage                                     ?   91.85%           
====================================================================
  Files                                        ?       20           
  Lines                                        ?     6093           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     5597           
  Misses                                       ?      496           
  Partials                                     ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.