Repository navigation
support storage-only FP16 tensors - #1398
Open
zhangzhenghao wants to merge 9 commits into
Open
zhangzhenghao wants to merge 9 commits into
zhangzhenghao wants to merge 9 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 79.09% 78.17% -0.93%
==========================================
Files 92 90 -2
Lines 16459 16468 +9
==========================================
- Hits 13019 12874 -145
- Misses 3440 3593 +153
- Partials 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zhangzhenghao
force-pushed
the
feat/tensor-fp16-storage
branch
from
October 30, 2026 01:11
5e39e1a to
a36f4b3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DType, genericNewTensor[T float32 | uint16], rawUint16s()/Floats()backing-storage accessors, and independent graph-freeToFloat16/ToFloat32conversions.bytes data = 3, with element width selected by dtype. Tensor/protobuf payloads share backing storage through unsafe byte views; no dual writes or fallback decoder.pr-1398-fp16-storage, a mirror of this PR's head, so its diff contains only computation changes. Retarget it tomasterafter this PR merges.Verification
Passed locally with system Go 1.27.3 (no scratch modfile or dependency changes):
go test ./common/nn ./protocol -count=1go test -race ./common/nn ./protocol -count=1go test -tags=noasm ./common/nn ./protocol -count=1go test -gcflags=all=-d=checkptr=2 ./common/nn ./protocol -count=1go vet -composites=false ./common/nn ./protocolgit diff --checkThe split retains the original storage commits and subsequent accessor/conversion/serialization changes, while removing the computation commit entirely from this branch's history. The dependent computation tree is byte-for-byte identical to the previous combined PR head. Independent review found no split-induced omissions or blocking issues. GitHub Actions run 40984389040 passed all unit, integration, compatibility, playground, and lint jobs on this head. The separate Codecov project check failed: project coverage 78.17% (-0.93% versus base), patch coverage 91.38% with 5 missing/partial changed lines in tensor.go. This is a coverage check failure, not a test failure; no unrelated coverage changes were bundled into the split.