Repository navigation
support FP16 tensor computation through FP32 kernels - #1423
Open
zhangzhenghao wants to merge 1 commit into
Open
zhangzhenghao wants to merge 1 commit into
zhangzhenghao wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #1398 (FP16 tensor storage). This stacked PR targets
pr-1398-fp16-storage, an exact mirror of #1398's storage-only head, so its diff contains computation changes only. Merge #1398 first, then retarget this PR tomaster.Verification
Passed locally with system Go 1.27.3, without modifying go.mod/go.sum:
go test ./common/nn ./protocol -count=1go test -race ./common/nn ./protocol -count=1go test -tags=noasm ./common/nn ./protocol -count=1go vet -composites=false ./common/nn ./protocolgit diff --cached --checkThe resulting source tree exactly matches the former combined #1398 head
5e39e1a4a3cff412df6f6b12683f42ea96b30692(treeadea68644abaec590de64501a76736ae3ac40b13). No computation behavior was changed by the split. GitHub Actions currently filters pull requests tomaster/release-**, so this stacked PR does not trigger remote CI while targetingpr-1398-fp16-storage. Local verification above passed; remote CI must run after retargeting tomasteronce #1398 merges.