Repository navigation
Hide rankings with failed secret runs - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leaderboardrun passes while secretbenchmarkrun failsWhy
Kernelbot now filters these cases from its API, but kernelboard also queries the leaderboard DB directly. Without the same predicate, submissions that fail secret validation can still appear in kernelboard-rendered rankings or summaries.
The filter intentionally matches on
submission_idandrunner, notmode, because the observed QR issue has a visible publicleaderboardscore and a failed secretbenchmarkrun.Validation
uv run python -m py_compile kernelboard/api/leaderboard.py kernelboard/api/leaderboard_summaries.py kernelboard/index.py kernelboard/leaderboard.py ranking_worker.py tests/api/test_leaderboard_api.pygit diff --checkuv run ruff check kernelboard/api/leaderboard.py kernelboard/api/leaderboard_summaries.py kernelboard/index.py kernelboard/leaderboard.py tests/api/test_leaderboard_api.pyAttempted
REDIS_URL=redis://localhost:6380/0 uv run pytest -q tests/api/test_leaderboard_api.py, but the local fixture invokes barepsqlwith an environment that drops Homebrew's/opt/homebrew/binfromPATH, so it fails before tests run withFileNotFoundError: psqlon this machine.