Skip to content

Hide rankings with failed secret runs #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msaroufim merged 1 commit into from
Jun 17, 2026
Merged

Hide rankings with failed secret runs #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion kernelboard/api/leaderboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,18 @@ def _get_query():
JOIN leaderboard.submission s ON r.submission_id = s.id
LEFT JOIN leaderboard.user_info u ON s.user_id = u.id
LEFT JOIN submission_counts sc ON s.user_id = sc.user_id AND r.runner = sc.runner
WHERE NOT r.secret AND r.score IS NOT NULL AND r.passed AND s.leaderboard_id = %(leaderboard_id)s
WHERE NOT r.secret
AND r.score IS NOT NULL
AND r.passed
AND s.leaderboard_id = %(leaderboard_id)s
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
),

-- From ranked_runs, keep only the top run per user.
Expand Down Expand Up @@ -248,6 +259,14 @@ def get_custom_trend(leaderboard_id: int):
AND r.score IS NOT NULL
AND r.passed = true
AND NOT r.secret
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
ORDER BY s.submission_time ASC
"""
cur.execute(sql, (HARDCODED_USER_ID, leaderboard_id))
Expand Down Expand Up @@ -369,6 +388,14 @@ def get_user_trend(leaderboard_id: int):
AND r.score IS NOT NULL
AND r.passed = true
AND NOT r.secret
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
ORDER BY s.submission_time ASC
"""
cur.execute(sql, (*user_id_list, leaderboard_id))
Expand Down Expand Up @@ -455,6 +482,14 @@ def get_fastest_trend(leaderboard_id: int):
AND r.score IS NOT NULL
AND r.passed = true
AND NOT r.secret
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
ORDER BY s.submission_time ASC
"""
cur.execute(sql, (leaderboard_id,))
Expand Down
16 changes: 16 additions & 0 deletions kernelboard/api/leaderboard_summaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,14 @@ def _get_query_for_ids():
AND r.score IS NOT NULL
AND r.passed
AND s.leaderboard_id IN %s
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
),
personal_best_runs AS (
SELECT * FROM personal_best_candidates
Expand Down Expand Up @@ -466,6 +474,14 @@ def _get_query():
WHERE NOT r.secret
AND r.score IS NOT NULL
AND r.passed
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
),

-- Step 2: Select only the best run for each user
Expand Down
12 changes: 11 additions & 1 deletion kernelboard/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,17 @@ def index():
JOIN priority_gpu_types p on p.leaderboard_id = a.id
AND p.gpu_type = r.runner
LEFT JOIN leaderboard.user_info u ON s.user_id = u.id
WHERE NOT r.secret AND r.score IS NOT NULL AND r.passed
WHERE NOT r.secret
AND r.score IS NOT NULL
AND r.passed
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
),

-- Select only the best run for each user and GPU type.
Expand Down
13 changes: 12 additions & 1 deletion kernelboard/leaderboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,18 @@ def leaderboard(leaderboard_id: int):
FROM leaderboard.runs r
JOIN leaderboard.submission s ON r.submission_id = s.id
LEFT JOIN leaderboard.user_info u ON s.user_id = u.id
WHERE NOT r.secret AND r.score IS NOT NULL AND r.passed AND s.leaderboard_id = %(leaderboard_id)s
WHERE NOT r.secret
AND r.score IS NOT NULL
AND r.passed
AND s.leaderboard_id = %(leaderboard_id)s
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
),

-- From ranked_runs, keep only the top run per user.
Expand Down
8 changes: 8 additions & 0 deletions ranking_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ def ensure_snapshot_table(conn):
WHERE NOT r.secret
AND r.score IS NOT NULL
AND r.passed
AND NOT EXISTS (
SELECT 1
FROM leaderboard.runs sr
WHERE sr.submission_id = s.id
AND sr.secret
AND sr.runner = r.runner
AND sr.passed = FALSE
)
),

personal_best_runs AS (
Expand Down
92 changes: 92 additions & 0 deletions tests/api/test_leaderboard_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,95 @@ def test_leaderboard_no_submissions(client, app):

res = response.get_json()
assert res["data"]["rankings"] == {}


def test_failed_secret_benchmark_hides_public_leaderboard_run(client, app):
with app.app_context():
conn = get_db_connection()
with conn.cursor() as cur:
cur.execute(
"""
INSERT INTO leaderboard.submission
(id, leaderboard_id, file_name, user_id, code_id, submission_time, done)
VALUES
(900001, 339, 'hidden_secret_fail.py', '123456789012345', 13, NOW(), TRUE),
(900002, 339, 'visible_public_pass.py', '234567890123456', 13, NOW(), TRUE)
"""
)
cur.execute(
"""
INSERT INTO leaderboard.runs
(
id,
submission_id,
start_time,
end_time,
mode,
secret,
runner,
score,
passed,
compilation,
meta,
result,
system_info
)
VALUES
(
900001,
900001,
NOW(),
NOW(),
'leaderboard',
FALSE,
'H100',
-999,
TRUE,
'{}',
'{}',
'{}',
'{}'
),
(
900002,
900001,
NOW(),
NOW(),
'benchmark',
TRUE,
'H100',
NULL,
FALSE,
'{}',
'{}',
'{}',
'{}'
),
(
900003,
900002,
NOW(),
NOW(),
'leaderboard',
FALSE,
'H100',
-998,
TRUE,
'{}',
'{}',
'{}',
'{}'
)
"""
)
conn.commit()

response = client.get("/api/leaderboard/339")
assert response.status_code == 200

payload = response.get_json()
h100_rankings = payload["data"]["rankings"]["H100"]
ranked_files = {row["file_name"] for row in h100_rankings}

assert "hidden_secret_fail.py" not in ranked_files
assert "visible_public_pass.py" in ranked_files
Loading