Repository navigation
Extend Modal runner timeout - #496
Merged
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
msaroufim
force-pushed
the
investigate-modal-timeouts
branch
from
June 18, 2026 22:23
e997146 to
3624f8d
Compare
msaroufim
force-pushed
the
investigate-modal-timeouts
branch
from
June 18, 2026 22:25
3624f8d to
a63c110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Production Modal logs for
discord-bot-runnershow B200 runner inputs being cancelled at Modal's default 300 second function timeout, including a cancellation at2026-06-18 22:19:32 UTCthat lines up with the814188failure window:The deployed runner functions were registered without a Modal
timeout=argument, so the platform default could cancel the function before kernelbot's own timeout handling ran. Raising only the Modal platform timeout is not enough becausemodal_run_configstill had an internal 600s alarm; this PR sets both to the same one-hour envelope.Validation
uv run ruff check src/runners/modal_runner.py src/runners/modal_runner_archs.pyuv run python -m py_compile src/runners/modal_runner.py src/runners/modal_runner_archs.pygit diff --checkDeployment Note
After merge, the Modal runner app needs to be redeployed so the new function-level
timeout=3600is applied. Deploying only the Northflank service is not enough for this part.