Skip to content

Extend Modal runner timeout #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msaroufim merged 1 commit into from
Jun 18, 2026
Merged

Extend Modal runner timeout #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/runners/modal_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@
"modal_runner_archs",
)

MODAL_RUN_TIMEOUT_SECONDS = 60 * 60


class TimeoutException(Exception):
pass
Expand All @@ -111,7 +113,7 @@ def timeout_handler(signum, frame):

def modal_run_config( # noqa: C901
config: dict,
timeout_seconds: int = 600,
timeout_seconds: int = MODAL_RUN_TIMEOUT_SECONDS,
) -> FullResult:
"""Modal version of run_pytorch_script, handling timeouts"""
try:
Expand Down
22 changes: 15 additions & 7 deletions src/runners/modal_runner_archs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
# This file contains wrapper functions for running
# Modal apps on specific devices. We will fix this later.
from modal_runner import app, cuda_image, modal_run_config
from modal_runner import MODAL_RUN_TIMEOUT_SECONDS, app, cuda_image, modal_run_config

gpus = ["T4", "L4", "L4:4", "A100-80GB", "H100!", "B200"]
for gpu in gpus:
gpu_slug = gpu.lower().split("-")[0].strip("!").replace(":", "x")
app.function(gpu=gpu, image=cuda_image, name=f"run_cuda_script_{gpu_slug}", serialized=True)(
modal_run_config
)
app.function(gpu=gpu, image=cuda_image, name=f"run_pytorch_script_{gpu_slug}", serialized=True)(
modal_run_config
)
app.function(
gpu=gpu,
image=cuda_image,
name=f"run_cuda_script_{gpu_slug}",
serialized=True,
timeout=MODAL_RUN_TIMEOUT_SECONDS,
)(modal_run_config)
app.function(
gpu=gpu,
image=cuda_image,
name=f"run_pytorch_script_{gpu_slug}",
serialized=True,
timeout=MODAL_RUN_TIMEOUT_SECONDS,
)(modal_run_config)
Loading