Repository navigation
fix(time): 🐛 Fix Hour validation and minute wrapping - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a573f2318
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hour, and ensure minute arithmetic wraps correctly across day boundaries.Description
FORMAT_REGEXand strict parsing helpersparseFromStringandparseFromNumberto reject malformed strings and fractional numeric values inHour.addTrailZerofor consistent representation inHour.normalizeMinutesand updateaddMinutesto use modular arithmetic so additions/subtractions spanning multiple days wrap correctly.tests/value-objects/time/Hour.spec.tsfor invalid formats, fractional inputs, and multi-day minute arithmetic.Testing
yarn lintand it passed successfully.yarn test:unit --runInBand tests/value-objects/time/Hour.spec.tsand theHourtest suite passed.yarn test:unit --runInBandand all tests passed (39 test suites, 709 tests).yarn buildand the build completed successfully.Supersedes #2.
Codex Task