fix(time): 🐛 Fix Hour validation and minute wrapping

src/value-objects/time/Hour.ts

@@ -6,60 +6,72 @@ import { StringValueObject } from '../StringValueObject';
 export class Hour extends StringValueObject {
   private readonly minutes: string;
   private readonly hours: string;
-  private static addTrailZero(value: string): string {
-    return Number(value) < 10 ? `0${Number(value)}` : value;
+
+  private static addTrailZero(value: number): string {
+    return value < 10 ? `0${value}` : value.toString();
+  }
+
+  private static normalizeMinutes(totalMinutes: number): number {
+    const minutesPerDay = 24 * 60;
+
+    return ((totalMinutes % minutesPerDay) + minutesPerDay) % minutesPerDay;
+  }
+
+  private static parseFromNumber(value: number, minutes: number): string[] {
+    assert(
+      Number.isInteger(value) && value >= 0 && value <= 23,
+      new InvalidHourError(),
+    );
+    assert(
+      Number.isInteger(minutes) && minutes >= 0 && minutes <= 59,
+      new InvalidMinutesError(),
+    );
+
+    return [Hour.addTrailZero(value), Hour.addTrailZero(minutes)];
+  }
+
+  private static parseFromString(value: string): string[] {
+    const parts = value.split(':');
+
+    assert(parts.length === 2 && parts[1] !== '', new InvalidHourError());
+
+    const [hours, minutes] = parts;
+
+    assert(/^\d{1,2}$/.test(hours), new InvalidHourError());
+    assert(/^\d{1,2}$/.test(minutes), new InvalidMinutesError());
+
+    const parsedHours = Number(hours);
+    const parsedMinutes = Number(minutes);
+
+    assert(parsedHours >= 0 && parsedHours <= 23, new InvalidHourError());
+    assert(
+      parsedMinutes >= 0 && parsedMinutes <= 59,
+      new InvalidMinutesError(),
+    );
+
+    return [Hour.addTrailZero(parsedHours), Hour.addTrailZero(parsedMinutes)];
   }
 
   constructor(value: string);
   constructor(value: number, minutes?: number);
   constructor(value: string | number, minutes?: number) {
-    let parsedHours: string;
-    let parsedMinutes: string;
-
-    if (typeof value === 'number' && minutes !== undefined) {
-      assert(Number(value) >= 0 && Number(value) <= 23, new InvalidHourError());
-      assert(
-        Number(minutes) >= 0 && Number(minutes) <= 59,
-        new InvalidMinutesError(),
-      );
-
-      parsedHours = Hour.addTrailZero(value.toString());
-      parsedMinutes = Hour.addTrailZero(minutes.toString());
-    } else {
-      assert(typeof value === 'string', new InvalidHourError());
-      assert((value as string).includes(':'), new InvalidHourError());
-      const [hours, minutes] = (value as string).split(':');
-
-      assert(Number(hours) >= 0 && Number(hours) <= 23, new InvalidHourError());
-      assert(
-        Number(minutes) >= 0 && Number(minutes) <= 59,
-        new InvalidMinutesError(),
-      );
-      parsedHours = Hour.addTrailZero(hours);
-      parsedMinutes = Hour.addTrailZero(minutes);
-    }
+    const [parsedHours, parsedMinutes] =
+      typeof value === 'number' && minutes !== undefined
+        ? Hour.parseFromNumber(value, minutes)
+        : Hour.parseFromString(value as string);
 
     super(`${parsedHours}:${parsedMinutes}`);
     this.hours = parsedHours;
     this.minutes = parsedMinutes;
   }
 
   public addMinutes(minutes: number): Hour {
-    const totalMinutes = Number(this.minutes) + minutes;
-    let newHour = Number(this.hours) + Math.floor(totalMinutes / 60);
-    let newMinutes = totalMinutes % 60;
-
-    if (newHour > 23) {
-      newHour = newHour - 24;
-    } else if (newHour < 0) {
-      newHour = 24 + newHour;
-    }
-
-    if (newMinutes < 0) {
-      newMinutes = 60 + newMinutes;
-    }
+    const currentMinutes = Number(this.hours) * 60 + Number(this.minutes);
+    const normalizedMinutes = Hour.normalizeMinutes(currentMinutes + minutes);
+    const newHour = Math.floor(normalizedMinutes / 60);
+    const newMinutes = normalizedMinutes % 60;
 
-    return new Hour(`${newHour}:${newMinutes}`);
+    return new Hour(newHour, newMinutes);
   }
 
   public diffInMinutes(other: Hour): number {

tests/value-objects/time/Hour.spec.ts

@@ -13,9 +13,17 @@ describe('Hour', () => {
         expect(() => new Hour('24:00')).toThrow(InvalidHourError);
       });
 
+      it('should throw error if string format is invalid', () => {
+        expect(() => new Hour('23:')).toThrow(InvalidHourError);
+        expect(() => new Hour('23:10:15')).toThrow(InvalidHourError);
+        expect(() => new Hour('1.5:00')).toThrow(InvalidHourError);
+      });
+
       it('should throw error if minutes is invalid', () => {
         expect(() => new Hour('23:60')).toThrow('Invalid minutes');
         expect(() => new Hour('23:60')).toThrow(InvalidMinutesError);
+        expect(() => new Hour('12:xx')).toThrow(InvalidMinutesError);
+        expect(() => new Hour('12:3a')).toThrow(InvalidMinutesError);
       });
 
       it('should work with 0 hour', () => {
@@ -32,11 +40,13 @@ describe('Hour', () => {
       it('should throw error if hour is invalid', () => {
         expect(() => new Hour(24, 0)).toThrow('Invalid hour');
         expect(() => new Hour(24, 0)).toThrow(InvalidHourError);
+        expect(() => new Hour(1.5, 0)).toThrow(InvalidHourError);
       });
 
       it('should throw error if minutes is invalid', () => {
         expect(() => new Hour(23, 60)).toThrow('Invalid minutes');
         expect(() => new Hour(23, 60)).toThrow(InvalidMinutesError);
+        expect(() => new Hour(23, 1.5)).toThrow(InvalidMinutesError);
       });
 
       it('should work with 0 hour', () => {
@@ -100,6 +110,18 @@ describe('Hour', () => {
     it('should add more than 2 hours', () => {
       expect(new Hour('23:59').addMinutes(120).toString()).toEqual('01:59');
     });
+
+    it('should wrap additions spanning multiple days', () => {
+      expect(new Hour('23:59').addMinutes(24 * 60 + 2).toString()).toEqual(
+        '00:01',
+      );
+    });
+
+    it('should wrap subtractions spanning multiple days', () => {
+      expect(new Hour('00:00').addMinutes(-(24 * 60 + 1)).toString()).toEqual(
+        '23:59',
+      );
+    });
   });
 
   describe('diffInMinutes', () => {