Repository navigation
🐛 fix(intake): skip style, script and comment text when extracting HTML - #475
hivecommons-hive[bot] wants to merge 2 commits into
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Needs a decision, not a merge:
Head: verdict requires_human @87174d8, 4/4 checks green, DCO yes, soak 0s of 30m0s. What to do: approve this head ( How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Summary
StripTagsis now element-aware: HTML comments are skipped as a unit (even with>inside), and the full contents ofscript,style,noscriptandtemplate(case-insensitive, up to the matching closing tag or end of input) are dropped. Ordinary tags, spacing and entity unescaping are unchanged. Mirrors the RTF skipped-destination fix (#424).Before:
<p>a</p><style>p > b{}</style><!-- if x > 1 --><script>y()</script><p>b</p>leaked style/script/comment text into the idea.After:
a b.Closes #474
Validation
Added table-driven
TestStripTagsSkipsNonTextRegions. Not run locally; CI is the verdict.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88