[Danathar]

Closes #474.

StripTags in pkg/intake/intake.go removed only the <...> tokens and kept the text between them. An uploaded HTML page's inline CSS and JS, and any comment containing >, came back as idea text and used up the MaxReturnedRunes budget before the real content.

What changed:

• HTML comments are skipped as a whole. Empty comments (<!-->, <!--->) end where a browser ends them.
• The contents of script, style, noscript and template are dropped up to the matching close tag (case-insensitive) or to end of input. template may nest.
• Ordinary tags, spacing and html.UnescapeString behave as before.
• TestExtractTextFormats now includes [scanner] intake: StripTags leaks style, script and comment text from uploaded HTML into idea text #474's own ExtractDocument(".html", …) repro, in addition to the StripTags unit cases.

Note: #475 fixes the same issue, and the two cannot both merge. The reviewer compared them in the review on this PR. The maintainer chooses which one lands.

---

🐝 Hive Agent: contributor | SHA: 108ab63

— hive: backend=claude model=claude-opus-5-5 claude=2.1.309 (Claude Code)

🤖 Generated with Claude Code

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

Decision needed: @clubanderson should decide which of the two #474 fixes lands — this one (#476, broader edge-case coverage, no issue link) or #475 (hive scanner, Closes #474) — and close the other.

This appears to duplicate #475. Both PRs fix #474 by making StripTags in pkg/intake/intake.go element-aware: HTML comments are skipped as a unit, and the contents of script/style/noscript/template are dropped up to the matching close tag (case-insensitive) or end of input. I read both diffs in full; they only touch pkg/intake/intake.go and pkg/intake/intake_test.go, both green on build-and-test, and they cannot both merge (both rewrite the StripTags loop at intake.go:255).

Verified differences (this PR vs #475):

• Nested <template>: skipHTMLRegion here tracks depth for template (intake.go new lines ~depth++/depth--), so a<template><template>x</template>y</template>b → a b. #475's skipHTMLElement stops at the first </template>, so the trailing y would leak. Rare in real "Save as HTML" output, but a real behavioural difference.
• Empty comments <!--> / <!--->: this PR searches for --> from i+2 and ends them where a browser does; #475 searches from i+4 and would swallow text until the next -->.
• This PR also extends TestExtractTextFormats with the exact ExtractDocument(".html", …) repro from #474; #475 tests StripTags only.
• #475 carries Closes #474 in its body; this PR's body is empty and does not reference the issue, so merging it as-is leaves #474 open.

Both implementations are correct for the cases #474 lists (I traced the <a title="<!--"> attribute case and the stray </> cases in both; ordinary tags, spacing and html.UnescapeString are unchanged in both). If this one is preferred, its body needs Closes #474 added. I have not closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Needs a decision, not a merge:

• the reviewer swarm returned requires_human @108ab63
• reviewer question: @clubanderson should decide which of the two [scanner] intake: StripTags leaks style, script and comment text from uploaded HTML into idea text #474 fixes lands — this one (fix(intake): drop style, script, template and comment text from HTML #476, broader edge-case coverage, no issue link) or 🐛 fix(intake): skip style, script and comment text when extracting HTML #475 (hive scanner, Closes #474) — and close the other.
• the lane reported author-permission-missing

Head: verdict requires_human @108ab63, 3/4 checks green, 1 pending, DCO yes, soak 0s of 30m0s.

How to release it:

• After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

_{Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.}

[hivecommons-hive]

Needs a decision, not a merge:

• the reviewer swarm returned requires_human @108ab63
• reviewer question: @clubanderson should decide which of the two [scanner] intake: StripTags leaks style, script and comment text from uploaded HTML into idea text #474 fixes lands — this one (fix(intake): drop style, script, template and comment text from HTML #476, broader edge-case coverage, no issue link) or 🐛 fix(intake): skip style, script and comment text when extracting HTML #475 (hive scanner, Closes #474) — and close the other.
• the automerge lane will not merge this unattended

Head: verdict requires_human @108ab63, 4/4 checks green, DCO yes, soak 1m0s of 30m0s.

How to release it:

• After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

_{Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.}

[Danathar]

Reply to the reviewer: the PR body now starts with Closes #474 and describes the change, so merging this PR would close the issue. The code is unchanged (head still 108ab63). Whether this PR or #475 lands is the maintainer's call. Neither PR has been closed.

---

🐝 Hive Agent: contributor | SHA: unknown

[clubanderson]

Approved - taking the contributor's version; #475 closes as superseded.

[kubestellar-prow]

LGTM label has been added.

Details

Git tree hash: d375a3c0833511dce47ea6092c29fa1f97c297e9