Repository navigation
docs: add Crux section - #490
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Conclusion: the production change is consistent and does what the body says, but two test fixtures were not updated for the new project, which is why Run unit tests is red (run 40411365802).
scripts/sync-sibling-docs.test.ts:9-16—SIBLING_PROJECTSstill lists six projects.scripts/sync-sibling-docs.tsnow insertsproject: "crux"betweendibsandspektacular, soPROJECTS.map(p => p.project)no longer deep-equals the fixture (sync-sibling-docs.test.ts:26). Fix: add"crux"after"dibs"in the fixture (order matters fortoEqual).src/__tests__/check-internal-links-helpers.test.ts:284-293— the expectedPROJECT_FOR_NAVobject lacks theCRUX: "docs/crux"entry this PR adds toscripts/check-internal-links-helpers.ts. Fix: add that key to the expected object.
Everything else I read checks out: the .github/workflows/check-internal-links.yml hunk is a comment-only edit (line 71), the 19-file set matches the body's list (sync entry, committed snapshot at docs/content/crux/readme.md, nav, versions, sidebar/footer, shared.json, llms.txt, redirects, typos, changelog fragment), and lint/build/link checks are green. The Netlify preview failures are unrelated to the diff.
Once the two fixtures are updated this looks correct to me.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Correction to the earlier review comment on this PR: at head 6dbe4ae both test fixtures it flagged are already updated — the diff adds "crux" to SIBLING_PROJECTS (scripts/sync-sibling-docs.test.ts:15) and CRUX: "docs/crux" to the expected PROJECT_FOR_NAV object (src/__tests__/check-internal-links-helpers.test.ts:291), and the Run unit tests check is green on this head. That comment described an earlier push.
Read the rest against main: the crux entry is threaded consistently through scripts/sync-sibling-docs.ts (PROJECTS), STATIC_PROJECTS and knownProjects in src/app/docs/[...slug]/page.tsx, getProjectFromSlug in layout.tsx, and all three switch statements in src/app/docs/page-map.ts; shared.json, netlify.toml, llms.txt, _typos.toml and the changelog fragment match the body's list. Looks correct to me.
The only red checks are the Netlify deploy-preview family, which is the known free-tier quota exhaustion (#419), not this diff.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
6dbe4ae
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
…#492) getProjectFromPath's /docs/crux arm (added in #490) and rewriteDocLinks' reference-style definition fallbacks (added in #488) were the only lines and branches left unexecuted in those two files. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…slug layout (#498) getProjectFromSlug gained a crux arm in #490 but the SlugLayout table only pinned the other six projects, so dropping the arm would silently serve crux pages with the hive sidebar. isMetaNode's raw kind === 'Meta' check was also unreachable from buildPageMap(), which only yields nextra-normalized nodes; each arm is now exercised by a node only it can strip. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closes #489
Adds a Crux docs section at /docs/crux, synced from hivecommons/crux README (new entry in sync-sibling-docs, committed snapshot, nav, versions, sidebar/footer, shared.json, llms.txt, redirects, typos exclusion, changelog fragment).
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88