Skip to content

πŸ“– docs: add crux-lanes.md to hive sync list - #611

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-610
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-610

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Adds crux-lanes.md to the hive sync list so mirrored pages link internally instead of to GitHub.

Closes #610

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

βœ… Deploy Preview for hivecommons-docs canceled.

Name Link
πŸ”¨ Latest commit 4e8901d
πŸ” Latest deploy log https://app.netlify.com/projects/hivecommons-docs/deploys/6aeae01a1ef686618c6ab246

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me. Read scripts/sync-hive-docs.ts at 4e8901d and src/app/docs/page-map.ts:

  • src/docs/crux-lanes.md exists on hivecommons/hive@v5 (the configured HIVE_DOCS_REF default), so the prebuild sync will fetch it.
  • The route is derived from the target name (sync-hive-docs.ts:165-183), so links to crux-lanes.md now rewrite to /docs/hive/crux-lanes. That route resolves even without a nav entry because page-map.ts adds every content file to routeMap as a fallback (// Populate routeMap with all files for fallback resolution).
  • The mirrored docs/content/hive/crux-lanes.md is not in this diff; that matches how the mirrors are maintained (the hive-docs-refresh workflow commits them, cf. πŸ“– docs: resync the docs/content mirrors from upstreamΒ #609), so not a gap.

One suggestion, not a blocker: the three sibling crux pages each have a sidebar entry in page-map.ts (NAV_STRUCTURE_HIVE, lines 120–122: crux CLI, crux serve API, Publishing crux). Without a matching { 'Crux lanes': 'crux-lanes.md' } the page is reachable by link but not discoverable from the nav. #605 added nav entries alongside the sync-list entries; worth doing the same here or in a follow-up.

The red FOSSA license scan is infra, not this change: the job log ends with Revision for locator (custom+162/hivecommons/docs$…) was not found from the policy-test step; the same check is green on main.

Evidence bundle `#6114e8901d` sha256:49916e0682dc8f30958973d4aa698f116d417e15a8977264c7ebeb7e7b64a77b β€” download from the dashboard or `hivectl review evidence #611`.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified against the tree, not just the diff:

  • src/docs/crux-lanes.md exists on hivecommons/hive@v5 (the branch scripts/sync-hive-docs.ts:16 tracks), so the fetch at scripts/sync-hive-docs.ts:238 will succeed rather than hitting the process.exit(1) at line 285.
  • Adding the entry is sufficient for the issue's goal: basenameToSiteRoute (scripts/sync-hive-docs.ts:173-182) is built from the files list, so link-rewrite will turn the crux-lanes.md links in documentation-map.md, crux-serve.md and env-vars.md into /docs/hive/crux-lanes on the next resync β€” per #610 that is the whole ask.
  • The page renders without a nav entry: getAllDocFiles (src/app/docs/page-map.ts:63-89) walks docs/content/hive/ directly, and work-sources.md is the existing precedent (synced, not in NAV_STRUCTURE_HIVE, linked internally from documentation-map.md:201).

One optional follow-up, not a blocker: #604 paired each crux page with a sidebar entry (src/app/docs/page-map.ts:120-122). Adding { 'crux lanes': 'crux-lanes.md' } beside them would make the page discoverable from the Operations nav rather than only via inbound links. Could land here or as a separate XS change.

The failing check is FOSSA license scan, which this one-line TS change cannot have affected.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (correctness): crux-lanes.md is not in the hive sync list, so mirrored pages link out to GitHub for it

0 participants