Repository navigation
fix(nav): add synced crux-lanes and work-sources pages to the hive nav and guard all synced pages - #616
Conversation
…v and guard all synced pages Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs canceled.
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. Review findings from Correctness review @ e145a46 Logic verified: reproducing the new assertion against head yields 68 sync targets and Blocker (in-scope, agent-fixable): CI job TypeScript & ESLint fails in Prettier on the PR's own new test ( Advisory (low): Review findings from Intent alignment: the diff does what #614 asks — all three checkboxes land ( One in-scope blocker — the PR's own new test code fails CI's Reviewed by Reviewer notesReview @ d6c38bd — the prior blocker is cleared; this looks correct to me. What I verified in the tree, not just the diff:
No findings. Reviewed by Reviewer notesRead the tree at
Only PR-body/diff gap I checked for: none. No findings. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
docs-currency review @ e145a46
Nav and changelog content are correct: both new entries (src/app/docs/page-map.ts:121, :124) match the section/title decision in #614, and every source/target in scripts/sync-hive-docs.ts:21-99 (including the multi-line route-only stable-soak-policy.md entry at :47-50) resolves in NAV_STRUCTURE_HIVE. The fragment changelog.d/fixed-614-hive-nav-crux-lanes-work-sources.md follows the changelog.d/README.md format.
Blocking (in-scope): the required TypeScript & ESLint check fails on this head — Prettier rejects the new test block src/__tests__/page-map-adr-nav-drift.test.ts:20-34 (CI job 126506490353: [warn] src/__tests__/page-map-adr-nav-drift.test.ts … Run Prettier with --write to fix). Reproduced with the repo's .prettierrc.json: lines 21-22, 24-27 and 32 need wrapping. Fix: npx prettier --write src/__tests__/page-map-adr-nav-drift.test.ts and push.
Advisory (non-blocking): the new regex also matches localHiveDocs entries (scripts/sync-hive-docs.ts:104-107), so integrations.md is checked too. It is in the nav today (page-map.ts:103), so this is harmless, but the comment at :28 and the test name say "synced" — worth a one-word note so a future local-only page isn't mistaken for a sync regression.
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Fail loudly if NAV_STRUCTURE_HOTSHOT is missing instead of silently scanning the rest of page-map.ts, retitle the describe block now that the guard covers all synced pages, and note that localHiveDocs entries are intentionally included. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Closes #614
Why: #611 added
crux-lanes.mdto the sync list but the hand-maintainedNAV_STRUCTURE_HIVEwas not updated, so the page is served at/docs/hive/crux-lanesbut invisible in the sidebar;work-sources.mdhas drifted the same way since #58. The only drift guard (page-map-adr-nav-drift.test.ts) covered ADRs, so this class of omission could never fail CI.The test now also asserts every synced target in
scripts/sync-hive-docs.tsappears inNAV_STRUCTURE_HIVE, with an explicit (currently empty) allowlist for pages intentionally reachable by URL only. Without the two nav additions it fails on exactlycrux-lanes.mdandwork-sources.md.Both pages go under Operations next to the other crux operator pages, per the decision recorded in #614.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88