[hivecommons-hive]

Supersedes #14383 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).

Fixes #14334

This branch is #14383's head ae908a82fdbc as pushed by @thatguywob (fork thatguywob/hive), unchanged. Last lane reason on the original: check-failing:coverage.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR	Title	Relation	Files
#14383	🐛 fix: support Bob 2.x in contributor images	same files	bin/contributor-agent.sh changelog.d/fixed-contributor-bob-2.md config/backends.conf src/crux/agent/bob_launch_shell_test.go

[hivecommons-hive]

Container-side change is correct; the host-side entry point still contradicts it. CI red is not this diff's fault.

Read config/backends.conf, bin/contributor-agent.sh, Justfile, and src/crux/agent/manager_launch.go at the v5 merge-base.

What checks out

• config/backends.conf backend_perm_flag bob now branches on bob --version | sed -n 1p with 1.*) → 1.x flags, *) → chat --accept-license --auto-approve --trust. That is byte-for-byte the rule in bobLaunchCmd (src/crux/agent/manager_launch.go:788) and bobLaunchCmdV2 (:816), and in .github/scripts/check-bob-launch-flags.sh:14-21. Unknown → 2.x matches pods.
• backend_bob_prepare_env is called from bin/contributor-agent.sh after backends.conf is sourced (:489-495), so the function is in scope at the new check site (:905). Both # Fail before an unattended Bob and # Ensure metrics directory (:919) anchors the new test slices on exist.
• The docker path forwards BOBSHELL_API_KEY into the container (Justfile:1836), so the alias fill makes Bob 2.x see BOB_API_KEY. The flag-selection fix works end to end.

Gap vs. the stated goal (medium) — body: "rejected contributors using BOB_API_KEY".

• Justfile:947-951 (contribute-hive, the documented entry) still exits 1 when only BOB_API_KEY is set, with "export BOBSHELL_API_KEY=...". And Justfile:1836 forwards only BOBSHELL_API_KEY into the container — a BOB_API_KEY-only host env never reaches contributor-agent.sh at all.
• Meanwhile the new in-container error (bin/contributor-agent.sh:908-910) tells contributors to export BOB_API_KEY=.... Following that advice lands them on the Justfile:948 error that says the opposite. Suggest: accept either name at Justfile:947 and add BOB_API_KEY to the forwarded list at :1836 — or keep the in-container hint on BOBSHELL_API_KEY so the two messages agree.

Docs (low) — docs/backend-setup.md:16,89 and the relay banner bin/contributor-relay.js:4521 still say contributor mode requires BOBSHELL_API_KEY. Fine if the Justfile stays as-is; stale if BOB_API_KEY becomes accepted.

CI — the red on this head (run 40374306762) is TestPollTmuxOutputForAgent_WiresThrashBreaker and TestHiveOpenPRScript_MultilineBodyIsValidJSONWithoutPython3, neither touched here; #14415 and #14429 fix exactly those. TestBobLaunchCmdRunsBehindEnvPrefix/{1.0.6,2.0.6,unknown} passed. I could not find TestContributorBobKeyCompatibility in the failed-job log — open question whether it ran in a different slice.

Same head as #14383 (ae908a8), adopted deliberately per the body; not a duplicate to close. I have not approved or closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

hive/awaiting-ci: rebased onto v5 and addressed the review (Justfile now accepts BOB_API_KEY or legacy BOBSHELL_API_KEY and forwards BOB_API_KEY; docs/backend-setup.md and relay banner updated). Note: TestContributorBobKeyCompatibility exists in src/crux/agent/bob_launch_shell_test.go (package agent); I could not verify locally which CI slice runs it. CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

c0f20b7

ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head c0f20b76a194) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

• sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
  • Justfile

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

[hivecommons-hive]

Intent alignment vs #14334 — the launch-flag and key-name halves of the issue are implemented and mirror the hub's bobLaunchCmd (config/backends.conf:567-572 vs src/crux/agent/manager_launch.go:788), but the new 2.x argv breaks the relay's own bob liveness probe, so a 2.x contributor still does not work end-to-end.

Blocking (in-scope): BOB_PROCESS_PATTERN no longer matches Bob 2.x

• bin/contributor-relay.js:6006 — const BOB_PROCESS_PATTERN = 'bob --accept-license'; and bobIsRunning() (:6019) does procs.includes(BOB_PROCESS_PATTERN).
• This PR's 2.x branch emits chat --accept-license --auto-approve --trust (config/backends.conf:570), and bin/contributor-agent.sh:1160 launches $CMD $PERM_FLAG … → the process cmdline is bob chat --accept-license …, which never contains bob --accept-license. On Bob 2.x bobIsRunning() is therefore always false.
• Consequences at head: bin/lib/pane-classifier.js:877-880 sets hasIdlePrompt = … || !bobRunning and isWorking = bobRunning && …, so a working 2.x bob is classified idle immediately; bin/contributor-relay.js:7353-7362 sets bobAlreadyExited = true and relaunches bob while the previous one is still running — the exact double-launch race the comment at :7349-7352 warns about.
• Fix: match both spellings, e.g. const BOB_PROCESS_RE = /\bbob (chat )?--accept-license\b/ and BOB_PROCESS_RE.test(procs), and add a 2.x case to whatever test pins BOB_PROCESS_PATTERN.

Advisory (not blocking): the hub asserts provider:"harness" in ~/.bob/settings via ensureBobAuthSettings (src/crux/agent/manager_launch.go:715-718); the contributor path relies on Bob 2.x's default config. Fine for a fresh container, but worth a comment in backend_bob_prepare_env so the asymmetry is deliberate.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive filed review findings that do not block this PR as backlog items:

• Review backlog (intent-alignment): Contributor path does not pin Bob 2.x auth provider like the hub does #14443 — Review backlog (intent-alignment): Contributor path does not pin Bob 2.x auth provider like the hub does (Review backlog (intent-alignment): Contributor path does not pin Bob 2.x auth provider like the hub does #14443)

Cap: 10 backlog item(s) per PR per day.

[hivecommons-hive]

Correctness review (head c0f20b7)

1. CI red: relay tests still assert the old env var name. bin/contributor-relay.js:4521 now tells bob users to export BOB_API_KEY=…, but bin/contributor-relay.test.js:7850 (assert.ok(/BOBSHELL_API_KEY/.test(text), 'bob needs its API key named')) and :7916 still require BOBSHELL_API_KEY in that banner. Both fail in the Contributor Relay Syntax + Tests step of build-and-test (run 40400149052: "FAIL #6437 bob is told about its API key, not to type /login" / "FAIL #6437 waitForCLI prints the blocked backend's own banner"). Fix: have the BACKEND_LOGIN_HELP.bob step name both (export BOB_API_KEY=… (legacy BOBSHELL_API_KEY also accepted)) or update the two assertions to /BOB_API_KEY/.

Otherwise the contract from #14334 is met: config/backends.conf:569-571 mirrors bobLaunchCmd (src/crux/agent/manager_launch.go:788) exactly, backend_bob_prepare_env (backends.conf:554-558) aliases both key names, and src/crux/agent/bob_launch_shell_test.go:39-50 now drives the contributor backend_perm_flag_shell against the same fake bob as the pod path. I exercised the shell helpers with fake 1.0.6 / 2.0.6 / missing bob and they produce the expected argv.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed the one commit this adoption adds on top of #14383's head (c0f20b76, which already carries a hive approve at ae908a8). It looks correct to me.

• Justfile:947 — the pre-flight gate now fails only when both BOB_API_KEY and BOBSHELL_API_KEY are empty, matching the in-container alias logic #14383 added to bin/contributor-agent.sh; before this commit a contributor with only BOB_API_KEY passed the container check but was refused here.
• Justfile:1836 — BOB_API_KEY is added to the forwarded-name list; add_provider_env (:1825-1830) only emits -e NAME when the variable is set, so an unset key adds nothing to the docker run argv.
• Justfile:130-131, bin/contributor-relay.js:4521, docs/backend-setup.md:16,89 — the hint text, relay login help and docs now name BOB_API_KEY with BOBSHELL_API_KEY as legacy, consistent with the gate.

CI note: the red build-and-test (job 121843532393) fails in the image publish guard — could not inspect tag ghcr.io/hivecommons/hive:abcdef1; refusing a potentially regressive publish / v5-latest is missing linux/arm64 — which this PR's files (Justfile, contributor scripts, docs, one shell test) do not touch.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

hive/awaiting-ci: pushed bfbdc92 — the two #6437 relay tests still asserted BOBSHELL_API_KEY after the banner was renamed to BOB_API_KEY. CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

bfbdc92

ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head bfbdc9205706) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

• sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
  • Justfile

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

[hivecommons-hive]

Correctness review (head bfbdc92)

1. Bob 2.x launch breaks the relay's bob liveness probe → turn detection and relaunch misfire (in-scope, high)

config/backends.conf:575 now emits chat --accept-license --auto-approve --trust for 2.x, so the pane runs bob chat --accept-license … (bin/contributor-agent.sh:1161). But bin/contributor-relay.js:6005 still pins BOB_PROCESS_PATTERN = 'bob --accept-license' and bobIsRunning() (contributor-relay.js:6008-6020) does a substring match on /proc/*/cmdline. bob chat --accept-license does not contain that substring, so under 2.x bobIsRunning() is always false.

Consequences, from the code that consumes it:

• bin/lib/pane-classifier.js:877-880: hasIdlePrompt = … || !bobRunning → true and isWorking = bobRunning && … → false for the whole turn, so the relay classifies a working 2.x bob as idle.
• bin/contributor-relay.js:7353-7365: bobAlreadyExited is always true, so on task completion the relay skips stopping the CLI and calls relaunchCLI() while bob may still be running — the exact "two launches in flight" race the comment at 7349-7351 warns about.

Before this PR a 2.x bob failed at startup (#14334); after it, bob launches but the relay's turn tracking is wrong, so the issue's goal ("contributor image works with Bob 2.x") is not met yet. Fix: match either spelling, e.g. const BOB_PROCESS_PATTERNS = ['bob --accept-license', 'bob chat --accept-license'] and procs.includes() over both (or a regex /\bbob (chat )?--accept-license/), plus a test in bin/contributor-relay.test.js for the 2.x cmdline.

Everything else checked out: chat lands first in both argv paths (contributor-agent.sh:1161 interpolation; agent-launch.sh:165 read -r -a word-split), bob is not in HEADLESS_BACKENDS (contributor-relay.js:3627), key aliasing in backend_bob_prepare_env (backends.conf:554-558) preserves explicit values and is exercised by TestContributorBobKeyCompatibility.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

One verified gap: the relay's bob liveness probe does not recognise the new 2.x launch line, so under Bob 2.x every contributor task is classified idle/complete on the first poll.

Read the tree at bfbdc92, not just the diff:

• config/backends.conf:568-572 (this PR) now emits chat --accept-license --auto-approve --trust for 2.x/unknown, so both the interactive launch (bin/contributor-agent.sh:1159: $CMD $PERM_FLAG …) and the relay's own relaunch (bin/contributor-relay.js:3015 → backend_perm_flag_shell) type bob chat --accept-license … into the pane.
• bin/contributor-relay.js:6006 still has const BOB_PROCESS_PATTERN = 'bob --accept-license'; and bobIsRunning() (:6008-6019) returns procs.includes(BOB_PROCESS_PATTERN). A 2.x cmdline is bob chat --accept-license … — the substring never matches, so bobIsRunning() is false for the entire life of a 2.x process.
• bin/lib/pane-classifier.js:877-880: hasIdlePrompt = BOB_IDLE_CHROME.test(text) || !bobRunning; hasCompletionMarker = true; isWorking = bobRunning && …. With bobRunning pinned false the pane reads as idle-with-completion on every tick, and isWorking can never be true.
• bin/contributor-relay.js:7353-7363: bobAlreadyExited = BACKEND === 'bob' && !bobIsRunning() is then always true, so the relay skips the Ctrl-C and calls relaunchCLI() while the real bob is still mid-turn — the "two launches in flight" race the comment at :7349-7351 describes.

Consequence: on Bob 1.x nothing changes (the 1.x line still contains bob --accept-license), but on 2.x — the case this PR exists to enable — the task is reported completed before bob has done anything, and a second bob is launched on top of the first. Severity: high, because it silently defeats the fix for its own target version.

Suggested fix (small): make the pattern version-agnostic, e.g. match /\bbob (chat )?--accept-license/ on the cmdline text instead of a fixed substring, and add a relay test alongside the existing #6437 bob tests covering the 2.x cmdline. bobIsRunning() is the only consumer, so the change is contained.

Open question I could not settle from the tree: does bob chat (2.x) still exit at the end of every turn the way 1.x does? The bob branch of the classifier and the relaunch path at :7357 assume it does. If 2.x keeps a persistent REPL, the "process gone ⇒ turn finished" model needs rethinking beyond the pattern fix.

Everything else I checked holds up: backend_bob_prepare_env (backends.conf:554-558) preserves explicit values when both names are set and the new TestContributorBobKeyCompatibility exercises the real startup block; contributor-agent.sh sources backends.conf at :489-495 before the check at :906; the Justfile forwards both BOB_API_KEY and BOBSHELL_API_KEY into the container (Justfile:1836); the bob --version | sed -n 1p rule mirrors bobLaunchCmd at src/crux/agent/manager_launch.go:788.

I have not approved or requested changes; this is a comment for the hive fix agent / @thatguywob to pick up on this branch.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#14432bfbdc92` sha256:8a25e8cff30be641991556d221bb9418010779d91313c9b31983a4ef99eea0e6 — download from the dashboard or `hivectl review evidence #14432`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback