Skip to content

πŸ“– docs: explain contributor Bob auth provider - #14456

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Karibhou:docs/14443-bob-auth-asymmetry
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Karibhou:docs/14443-bob-auth-asymmetry

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Closes #14443

Explain why the contributor Bob 2.x path relies on the default auth provider while hub agents pin harness, including the effect of existing settings.

Validation: git diff --check; tests not run because this only changes a comment.

β€” hive: backend=codex

Hive-Run: hivecommons#14443
Hive-Plan: contributor Bob auth asymmetry
Hive-Spec: issue-14443#provider-documentation
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 26, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment-only change; I checked the claim it makes rather than the prose. Looks accurate to me.

  • src/crux/agent/manager_launch.go:713-718 (v5) documents that Bob 2.x selects auth by config provider, that the default user config carries provider:"harness", and that ensureBobAuthSettings asserts that provider so stale persisted settings cannot override it β€” which is the hub-side behaviour the new comment contrasts against.
  • backend_bob_prepare_env (config/backends.conf:554-558) only exports BOB_API_KEY/BOBSHELL_API_KEY and never touches ~/.bob/settings, so "existing Bob settings can select a different provider" is a correct description of the contributor path.
  • This matches the ask in #14443 (document the deliberate asymmetry; severity info). The diff is three comment lines in a shell config, so the red test (agent 5/5) check cannot be caused by it.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (agent 5/5)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Check report: the red agent shard here is TestPollTmuxOutputForAgent_WiresThrashBreaker (3/3 runs), which is shared-CI incident #14406 β€” it fails on every fork PR whose shard picks it up on ubuntu-latest while v5 is green, so it is not caused by this diff. The fix is #14415 (awaiting human merge). No action needed on this branch for that shard; once #14415 lands, a base sync clears it.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 26, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head c455b12420f0 has not moved for 3h1m and the hive has nothing it can push: adoption-stalled:check-failing:coverage.

Blocker: lane reason contributor-lane:claim-tier-untrusted on this head and nothing changed.

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@hivecommons-hive hivecommons-hive Bot removed the stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) label Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head c455b12420f0 has not moved for 3h6m and the hive has nothing it can push: adoption-stalled:check-failing:coverage.

Blocker: lane reason contributor-lane:claim-tier-untrusted on this head and nothing changed.

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

Base-sync: pick up hivecommons#14415 and hivecommons#14469 test fixes so CI runs against the current v5.
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: base-synced this adopted branch with v5 (merge commit, contributor commits and sign-offs untouched) so it picks up the test fixes from #14415 and #14469 that the red test (agent) / test (rest 4/4) shards were missing. CI pending β€” the lane re-evaluates the new head.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: b05e7ba6f

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot removed the stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue label Oct 27, 2026
@hivecommons-hive hivecommons-hive Bot added the stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) label Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Checked the comment's two factual claims against v5:

  • Hub side does pin the provider: src/crux/agent/bob_settings.go:338-339 sets settings[BobV2ProviderKey] = "harness", called from manager.go:1802 via ensureBobAuthSettings.
  • Contributor side does not: bin/contributor-agent.sh:906 only calls backend_bob_prepare_env, which exports BOB_API_KEY/BOBSHELL_API_KEY and nothing else.
  • "Existing Bob settings can therefore select a different provider" matches the hub's own rationale at bob_settings.go:243-244 ("the persisted provider still outranks the default").

#14443 asked for exactly this comment (its blocker #14432 has since merged), so Closes #14443 is right. Comment-only change; git diff --check is sufficient validation.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) labels Oct 27, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 23ca3e8 into hivecommons:v5 Oct 27, 2026
66 of 69 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#14456ecd7800` sha256:4722e2e6552d1153ba2cab1e9df7524d56073b4d2a684e45c00661cfb19d9cde β€” download from the dashboard or `hivectl review evidence #14456`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for β‰₯30m, reviewer verdict approve, head ecd780025832 adopted by the hive (stage/074-adopted-by-hive) with @Karibhou's commits β€” merged under the hive's own authority.

@hivecommons-hive hivecommons-hive Bot removed role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (intent-alignment): Contributor path does not pin Bob 2.x auth provider like the hub does

1 participant