Repository navigation
π docs: explain contributor Bob auth provider - #14456
hivecommons-hive[bot] merged 2 commits into
Conversation
Hive-Run: hivecommons#14443 Hive-Plan: contributor Bob auth asymmetry Hive-Spec: issue-14443#provider-documentation Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Comment-only change; I checked the claim it makes rather than the prose. Looks accurate to me.
src/crux/agent/manager_launch.go:713-718(v5) documents that Bob 2.x selects auth by config provider, that the default user config carriesprovider:"harness", and thatensureBobAuthSettingsasserts that provider so stale persisted settings cannot override it β which is the hub-side behaviour the new comment contrasts against.backend_bob_prepare_env(config/backends.conf:554-558) only exportsBOB_API_KEY/BOBSHELL_API_KEYand never touches~/.bob/settings, so "existing Bob settings can select a different provider" is a correct description of the contributor path.- This matches the ask in #14443 (document the deliberate asymmetry; severity info). The diff is three comment lines in a shell config, so the red
test (agent 5/5)check cannot be caused by it.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
Check report: the red agent shard here is π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
@Karibhou the hive has adopted this PR ( |
|
The hive adopted this PR ( Blocker: lane reason Moving to |
|
The hive adopted this PR ( Blocker: lane reason Moving to |
Base-sync: pick up hivecommons#14415 and hivecommons#14469 test fixes so CI runs against the current v5. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: base-synced this adopted branch with π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Looks correct to me. Checked the comment's two factual claims against v5:
- Hub side does pin the provider:
src/crux/agent/bob_settings.go:338-339setssettings[BobV2ProviderKey] = "harness", called frommanager.go:1802viaensureBobAuthSettings. - Contributor side does not:
bin/contributor-agent.sh:906only callsbackend_bob_prepare_env, which exportsBOB_API_KEY/BOBSHELL_API_KEYand nothing else. - "Existing Bob settings can therefore select a different provider" matches the hub's own rationale at
bob_settings.go:243-244("the persisted provider still outranks the default").
#14443 asked for exactly this comment (its blocker #14432 has since merged), so Closes #14443 is right. Comment-only change; git diff --check is sufficient validation.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, head |
Closes #14443
Explain why the contributor Bob 2.x path relies on the default auth provider while hub agents pin
harness, including the effect of existing settings.Validation:
git diff --check; tests not run because this only changes a comment.β hive: backend=codex