[hivecommons-hive]

The slog fleet feed now skips failed to send kick warnings whose error is the deliberate post-restart kick hold (#7363). Other kick send failures stay reportable. Adds a slogfeed test.

Closes #14422

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR	Title	Relation	Files
#14430	🐛 fix: exclude contributor tier limits from runtime self-reports	CONFLICT	src/pkg/fleetreport/slogfeed/slogfeed_test.go
#14365	🐛 fix: exclude expected CI merge refusals from fleet reports	CONFLICT	src/pkg/fleetreport/slogfeed/slogfeed_test.go

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me.

Traced the mechanism end to end rather than just the diff:

• Producer: src/cmd/hive/eval_cycle_seams.go logs logger.Warn("failed to send kick", "agent", msg.Agent, "error", out.sendErr) — the error is a record attr under key error, which is exactly what expectedKickHold iterates (src/pkg/fleetreport/slogfeed/slogfeed.go:129-140); bound attrs are not involved.
• SendKick returns restartKickHoldErrLocked's error unchanged (manager_kick.go:137-139, 207-209), and that error is built with %w on errKickHeldAfterRestart (kick_cancel.go:15, 59-60), so a.Value.String() contains the literal kick held after restart the filter matches. Other failed to send kick errors (tmux, inference blocks) keep flowing to ClassUnclassifiedRepeated, as the test asserts.

One heads-up for whoever merges: the conflicts-with-open-pr label is a textual conflict with #14430 — both append a new test at slogfeed_test.go:381. The changes are independent (#14430 edits fleetreport.IsBenignMessage, this edits Handler.feed), so whichever lands second needs a trivial rebase, nothing more.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#144342809a86` sha256:9d59d59eede1e1b0a38129398aea30912c7555db7990abf2ee8d34d176749553 — download from the dashboard or `hivectl review evidence #14434`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback