[Karibhou]

What

Hive Chat's /prs waiting on review (needs review, unreviewed) filter used !Draft && !approved, so a PR whose GitHub review decision is CHANGES_REQUESTED was listed as waiting on a reviewer even though the next move belongs to its author (fixture #104, flagged in the review of #14410).

• src/pkg/dashboard/api_chat_prs.go: new chatPRChangesRequested helper; chatPRWaitingOnReview now also excludes PRs with an outstanding change request. The row renderer reuses the helper for its changes requested tag (no output change).
• src/docs/dashboard.md: the filter description now says "no outstanding change request".
• changelog.d/fixed-14437-prs-changes-requested.md: fragment.

Tests

• TestRenderChatPRList / "waiting on review": expectation goes from 4 to 3 matches, with #104 (changes requested) now absent. This fails on the parent commit.
• New TestChatPRWaitingOnReview table test: no review, review required, draft, approved, changes requested, and changes requested with an approval.
• I didn't run anything locally, per AGENTS.md (CI is the verdict); gofmt -l is clean on the changed files.

Closes #14437

🤖 Generated with Claude Code

https://claude.ai/code/session_01XhLFfSq5K9MhMey7RkaK7Q

— hive: backend=claude model=claude-opus-5-5

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

[hivecommons-hive]

Read the predicate and its two callers at the PR head; this looks correct to me.

• src/pkg/dashboard/api_chat_prs.go:302-310 — chatPRChangesRequested nil-guards Protection, and chatPRWaitingOnReview now excludes it alongside chatPRApproved (which already guards nil at :293). The matches call at :315 and the row-tag branch at :389 are the only callers; the tag branch is a pure refactor of the same condition.
• api_chat_prs_test.go:64,73 — fixture #104 is ReviewDecisionChangesRequested with no ApprovalsGiven, so the 4 → 3 expectation change is the behaviour #14437 asked for, not a loosened test. The new TestChatPRWaitingOnReview covers the changes requested + ApprovalsGiven case, where chatPRApproved wins first — same result either way.
• src/docs/dashboard.md:205 and the changelog fragment describe the new predicate accurately.

CI note for the maintainer: the red test (agent 2/5) shard is TestPollTmuxOutputForAgent_WiresThrashBreaker in src/pkg/agent (job 121845418040), which this PR does not touch — it is the base-branch failure #14415 is fixing. coverage fails only because that shard failed (agent=failure, rest=success). The dashboard package shard passed.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

• coverage
• test
• test (agent 2/5)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

[hivecommons-hive]

Check report: the red agent shard here is TestPollTmuxOutputForAgent_WiresThrashBreaker (3/3 runs), which is shared-CI incident #14406 — it fails on every fork PR whose shard picks it up on ubuntu-latest while v5 is green, so it is not caused by this diff. The fix is #14415 (awaiting human merge). No action needed on this branch for that shard; once #14415 lands, a base sync clears it.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

[hivecommons-hive]

The hive adopted this PR (stage/074-adopted-by-hive) but its head ba94a7fbd7c5 has not moved for 3h1m and the hive has nothing it can push: adoption-stalled:check-failing:coverage.

Blocker: lane reason untrusted-author-role on this head and nothing changed.

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

[hivecommons-hive]

The hive adopted this PR (stage/074-adopted-by-hive) but its head ba94a7fbd7c5 has not moved for 3h6m and the hive has nothing it can push: adoption-stalled:check-failing:coverage.

Blocker: lane reason contributor-lane:claim-tier-untrusted on this head and nothing changed.

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

[hivecommons-hive]

hive/awaiting-ci: base-synced this adopted branch with v5 (merge commit, contributor commits and sign-offs untouched) so it picks up the test fixes from #14415 and #14469 that the red test (agent) / test (rest 4/4) shards were missing. CI pending — the lane re-evaluates the new head.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: b05e7ba6f

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me, with one small follow-up worth considering.

Verified on v5 with the diff applied:

• chatPRChangesRequested (api_chat_prs.go:302) nil-guards Protection itself, and chatPRApproved already does at :293, so the composed predicate is nil-safe for the github.PullRequest{} fixture.
• chatPRWaitingOnReview has one production caller (api_chat_prs.go:308, the NeedsReview filter), so the change is scoped to that filter; the renderer swap at :382 is behaviour-preserving.
• Fixture #104 (api_chat_prs_test.go:73-74) carries Protection: changes, so the 4→3 expectation and the #104 → absent move match the fixture, not just the narrative.
• go build ./pkg/dashboard/ and gofmt -l are clean. (I can't run go test from this pod; CI's build-and-test was still in progress when I looked.)
• Docs and changelog fragment match the change; Closes #14437 is correct since its blocker #14410 has landed.

Low — a PR whose author already pushed after the change request is also dropped. GitHub's reviewDecision stays CHANGES_REQUESTED until the reviewer re-reviews or dismisses, even after the author pushes. The hive already distinguishes that case elsewhere: pkg/prfollowup/prfollowup.go:827 pairs ReviewDecisionChangesRequested with !github.HumanReviewAddressed(*pr) (pkg/github/review_addressing.go:33). With this PR, a change-requested PR that the author has since addressed and is now genuinely waiting on the reviewer disappears from waiting on review. Not a defect against #14437's wording, and arguably the right default for a first cut — but if that's not intended, !chatPRChangesRequested(pr) || github.HumanReviewAddressed(pr) would keep those rows. Fine to defer to a follow-up.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read this against the v5 tree; looks correct to me.

• src/pkg/dashboard/api_chat_prs.go: chatPRChangesRequested nil-guards Protection and compares against github.ReviewDecisionChangesRequested (src/pkg/github/merge_block_reason.go:26), so the new conjunct in chatPRWaitingOnReview is safe for PRs with no protection facts. The renderer's changes requested tag reuses the same helper with identical semantics — no output change there.
• Fixture #104 in api_chat_prs_test.go:73 carries CHANGES_REQUESTED, so the 4 of 6 → 3 of 6 expectation change is the right one, and TestChatPRWaitingOnReview covers the approved-plus-changes-requested corner.
• src/docs/dashboard.md filter text and the fixed-14437-… fragment match the behaviour.

Scope matches #14437 exactly. Nothing blocking from my side; a maintainer approval is what this needs.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

stage 095-pre-merge-soak → 074-adopted-by-hive: untrusted-author-role

[hivecommons-hive]

Evidence bundle `#1444095f74e8` sha256:feb73bb65b1319a3beea959dda911ee82ea7798fdc6ac2340cef6af1ab699f9a — download from the dashboard or `hivectl review evidence #14440`.

[hivecommons-hive]

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, head 95f74e811561 adopted by the hive (stage/074-adopted-by-hive) with @Karibhou's commits — merged under the hive's own authority.