Skip to content

πŸ› fix: stage tracker verb β€” forward transitions no longer read as "fell back to" - #15222

Merged
clubanderson merged 1 commit into
v5from
fix/stage-transition-wording
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/stage-transition-wording

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15220

Root cause

stageTrackerEventText (SPA, src/pkg/dashboard/static/index.html) chose the event-line verb from the raw stage number: back = next.stage < prev.stage. Any numeric decrease read as "fell back to", including hops that are forward or neutral on the ladder β€” 015 β†’ 010 (triage accepted), 017/045 β†’ 010 (gap confirmed / decision made), 085 β†’ 080 (PR decision made), 072/071 β†’ 070 (author resumes), 070 β†’ 050 (fix pushed). The stage engine already classifies these in stagelabels.IsRegression, but the tracker payload did not expose that.

Fix

  • /api/stage-tracker stages[] rows carry falls_to: the lower same-kind stage numbers a move to which IsRegression calls a fall.
  • The SPA says "fell back to" only when the previous stage's falls_to lists the new stage; every other hop reads "moved to". The "β€” caption" suffix is kept on any lower-numbered hop so the line still explains what happened. Without falls_to (older payload) behaviour is unchanged.

Before / after

hop before after
015 β†’ 010, triage accepted Hive: fell back to Actionable β€” Triaged and eligible; waiting for the scanner to pick it up Hive: moved to Actionable β€” Triaged and eligible; waiting for the scanner to pick it up
085 β†’ 080, decision made fell back to Merge gate β€” … moved to Merge gate β€” …
072 β†’ 070, author resumes fell back to Fixing moved to Fixing
060 β†’ 050, changes requested fell back to CI / Review β€” a reviewer requested changes unchanged
040 β†’ 010, covering PR closed fell back to Actionable β€” … unchanged

Tests

… back to"

The Activity Monitor event line chose its verb from the raw stage number
alone, so triage accepted (015 β†’ 010), a decision made (085 β†’ 080) and the
author resuming (072 β†’ 070) all read "fell back to". The stage table now
carries falls_to from stagelabels.IsRegression and the SPA says "fell back
to" only for those hops; everything else reads "moved to", keeping the
"β€” caption" suffix.

Fixes #15220

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15191 πŸ› Let hive decide on a ready-for-human-merge PR approves and lets the sweep merge it same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15221 ✨ Activity Monitor: Accept triage on the label-less reporter-trust hold, leading the row menu same files src/pkg/dashboard/static/index.html
#15216 πŸ› Sentinel: a dashboard Approve releases the head for good; skip Prow-rejected /lgtm + /approve same files src/docs/dashboard-sections.md
#15206 πŸ› Activity Monitor: delegated adopt-supersede reports executing β†’ adopted/could-not-adopt, routes workflow-path to the workflows blocker, re-adoption survives the mutation journal same files src/pkg/dashboard/static/index.html
#15186 πŸ› Activity Monitor: one coherent post-decision state for Let hive decide rows; 060 reviewed in CI / Review same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15134 πŸ› Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15122 πŸ› Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/pkg/dashboard/static/index.html
#15104 πŸ› Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_cues_test.go
src/pkg/dashboard/static/index.html
#15219 πŸ› fix: preserve human and owner PRs during delegated decisions same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15200 πŸ› fix: tracker history column wears a history mark, not a βœ“ same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15223 ✨ Soak countdown on every soak pill, with the live timer on hover same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@clubanderson
clubanderson merged commit 275055b into v5 Oct 29, 2026
83 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/stage-transition-wording branch October 29, 2026 01:35
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Tracker says "fell back to" for triage-accepted 015β†’010 forward transition

1 participant