Repository navigation
π fix: stage tracker verb β forward transitions no longer read as "fell back to" - #15222
Conversation
β¦ back to" The Activity Monitor event line chose its verb from the raw stage number alone, so triage accepted (015 β 010), a decision made (085 β 080) and the author resuming (072 β 070) all read "fell back to". The stage table now carries falls_to from stagelabels.IsRegression and the SPA says "fell back to" only for those hops; everything else reads "moved to", keeping the "β caption" suffix. Fixes #15220 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15220
Root cause
stageTrackerEventText(SPA,src/pkg/dashboard/static/index.html) chose the event-line verb from the raw stage number:back = next.stage < prev.stage. Any numeric decrease read as "fell back to", including hops that are forward or neutral on the ladder β 015 β 010 (triage accepted), 017/045 β 010 (gap confirmed / decision made), 085 β 080 (PR decision made), 072/071 β 070 (author resumes), 070 β 050 (fix pushed). The stage engine already classifies these instagelabels.IsRegression, but the tracker payload did not expose that.Fix
/api/stage-trackerstages[]rows carryfalls_to: the lower same-kind stage numbers a move to whichIsRegressioncalls a fall.falls_tolists the new stage; every other hop reads "moved to". The "β caption" suffix is kept on any lower-numbered hop so the line still explains what happened. Withoutfalls_to(older payload) behaviour is unchanged.Before / after
Hive: fell back to Actionable β Triaged and eligible; waiting for the scanner to pick it upHive: moved to Actionable β Triaged and eligible; waiting for the scanner to pick it upfell back to Merge gate β β¦moved to Merge gate β β¦fell back to Fixingmoved to Fixingfell back to CI / Review β a reviewer requested changesfell back to Actionable β β¦Tests
TestStageTrackerStagesFallsTo(Go): the stage table marks 015β010, 017β010, 045β010, 085β080, 072β070, 070β050 as not-a-fall and 040β010, 060β050, 080β070 as falls; PR stages never fall to issue stages.TestStageTrackerCuesNode: new assertions for the verb with afalls_to-bearing ladder, including the observed β¨ feature: enqueue into GitHub's native merge queue instead of skipping with merge-queue-requiredΒ #15198 line. Notime.Sleep.